QueryDefinition: Adds API to get query parameters #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
force-pushed
the
expose-query-parameters
branch
from
95764d5
to
8bfe20b
Compare
thomaslevesque
commented
Feb 10, 2021
| public IReadOnlyList<(string Name, object Value)> GetQueryParameters() | ||
| { | ||
| return this.parametersAdapter ??= new ParametersListAdapter(this); | ||
| } |
There was a problem hiding this comment.
I exposed the parameters through a method because that's the API we agreed upon, but I think it might be more natural to expose them as a property.
If you agree, I can make that change. The name Parameters is already taken by an internal property, so we could either rename the existing property, or find another name for the new one (I lean toward the former).
thomaslevesque
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
This was referenced Feb 10, 2021
j82w
approved these changes
Feb 11, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kirankumarkolli
approved these changes
Feb 11, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose the parameters of a
QueryDefinitionas a list of tuplesThis PR also introduces a small unrelated optimization to
QueryDefinition, as a separate commit (so I can easily remove it from this PR if requested)Type of change
Closing issues
Closes #2191
Closes #796
Supersedes #802