Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Fixes TaskCanceledException being converted to InternalServerError and losing diagnostics #2424

Merged
merged 9 commits into from
Apr 23, 2021

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Apr 23, 2021

Pull Request Template

Description

This fixes a regression introduced by the pagination library where query is incorrectly converting operation cancelled exceptions into InternalServerErrors, and then does not include the diagnostics. Query now throws the expected CosmosOperationCancelledException which is an OperationCancellationTokenException with CosmosDiagnostics. This PR adds baseline tests, so we can assert the behavior.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

closes ##2065 Introduced in 3.14.0 in #1812

@j82w j82w changed the title Users/jawilley/query/tracing on cancellation token Query: Fixes TaskCanceledException being converted to InternalServerError and losing diagnostics Apr 23, 2021
neildsh
neildsh previously approved these changes Apr 23, 2021
@j82w j82w dismissed stale reviews from ealsur and neildsh via f441ada April 23, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants