[Internal] Query : Fixes IndexMetrics Baselines #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leminh98
previously approved these changes
May 16, 2024
kirankumarkolli
previously approved these changes
May 16, 2024
adityasa
requested review from
khdang,
sboshra,
neildsh,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
leminh98
changed the title
neildsh
previously approved these changes
May 17, 2024
leminh98
approved these changes
May 17, 2024
kirankumarkolli
approved these changes
May 17, 2024
microsoft-github-policy-service
bot
deleted the
users/adityasa/UpdateIndexAdvisorBaselines
branch
kirankumarkolli
added a commit
that referenced
this pull request
May 17, 2024
* Initial commit * Fixing the permission tests * Disabled non-streaming order by for Trace Test. --------- Co-authored-by: Kiran Kumar Kolli <kirankk@microsoft.com>
Pilchie
pushed a commit
that referenced
this pull request
May 17, 2024
* Resolving conflicts * [Internal] Query : Fixes IndexMetrics Baselines (#4499) * Initial commit * Fixing the permission tests * Disabled non-streaming order by for Trace Test. --------- Co-authored-by: Kiran Kumar Kolli <kirankk@microsoft.com> * Removing the type not ported --------- Co-authored-by: Aditya <adityasa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR Updates the index advisor baselines in light of new emulator release 2.14.17. The new emulator support returning plain-text response for FeedOptions.IndexMetrics, which the SDK is able to request and receive (introduced in #4183)
Also fixing the permission tests: New service behavior not allowing container deletes with permissions
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber