Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ignore] Release: Fixes release versions #4503

Merged
merged 3 commits into from
May 17, 2024
Merged

[Ignore] Release: Fixes release versions #4503

merged 3 commits into from
May 17, 2024

Conversation

kirankumarkolli
Copy link
Member

@kirankumarkolli kirankumarkolli commented May 17, 2024 •
edited
Loading

Release: Fixes release versions

@kirankumarkolli kirankumarkolli marked this pull request as ready for review May 17, 2024 18:16
adityasa
adityasa previously approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adityasa adityasa added the auto-merge Enables automation to merge PRs label May 17, 2024
Pilchie
Pilchie previously approved these changes May 17, 2024
View reviewed changes
@adityasa @kirankumarkolli
[Internal] Query : Fixes IndexMetrics Baselines (#4499)
44e3bcc 
* Initial commit

* Fixing the permission tests

* Disabled non-streaming order by for Trace Test.

---------

Co-authored-by: Kiran Kumar Kolli <kirankk@microsoft.com>
@kirankumarkolli kirankumarkolli dismissed stale reviews from Pilchie and adityasa via 44e3bcc May 17, 2024 18:56
kundadebdatta
kundadebdatta approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Pilchie
Pilchie previously approved these changes May 17, 2024
View reviewed changes
@kundadebdatta kundadebdatta removed the auto-merge Enables automation to merge PRs label May 17, 2024
@kundadebdatta kundadebdatta added the auto-merge Enables automation to merge PRs label May 17, 2024
adityasa
adityasa approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Pilchie Pilchie disabled auto-merge May 17, 2024 23:04
@Pilchie Pilchie dismissed their stale review May 17, 2024 23:04

Trying to approve again.

@Pilchie Pilchie disabled auto-merge May 17, 2024 23:07
@Pilchie Pilchie merged commit f6377b7 into releases/3.39.2 May 17, 2024
21 checks passed
@Pilchie Pilchie deleted the users/kirankk/3.39.2_version_pr branch May 17, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundadebdatta kundadebdatta kundadebdatta approved these changes

@adityasa adityasa adityasa approved these changes

@Pilchie Pilchie Pilchie approved these changes

@ealsur ealsur Awaiting requested review from ealsur ealsur is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

Assignees
No one assigned
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirankumarkolli @Pilchie @adityasa @kundadebdatta