Refactored cosmos element serializer to remove v3 serializer dependency #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft.Azure.Cosmos/src/CosmosElements/CosmosElementSerializer.cs
Outdated
Show resolved
Hide resolved
added 2 commits
September 26, 2019 06:40
bchong95
reviewed
Oct 8, 2019
| { | ||
| get | ||
| { | ||
| IJsonWriter jsonWriter = null; |
There was a problem hiding this comment.
don't set to default of T. instead use an else.
kirankumarkolli
approved these changes
Oct 8, 2019
|
No longer relevant since it no longer needs to work in the v2 SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The v3 serializer code has public types which get leaked in the query core which is used in the v2 SDK. This removes those dependencies, and prevents the v2 SDK from needing to build the Cosmos Serializer code.
Type of change
Please delete options that are not relevant.