Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORDER BY Arrays and Objects #853

Merged
merged 16 commits into from
Oct 24, 2019
Merged

Conversation

bchong95
Copy link
Contributor

@bchong95 bchong95 commented Sep 26, 2019

ORDER BY Arrays and Objects

Description

Adds support to ORDER BY Arrays and Objects. The algorithm is arrays come before objects but after strings. comparing two arrays or two objects is done by comparing their hashes.

Internal PR:
https://msdata.visualstudio.com/_git/CosmosDB/commit/952ea1a412850770e417b892c25a11272fd119cb?path=%2FProduct%2FSDK%2F.net%2FMicrosoft.Azure.Documents.Client%2FQuery%2FDistinctMap.UnorderedDistinctMap.cs&gridItemType=2&mpath=%2FProduct%2FSDK%2F.net%2FMicrosoft.Azure.Documents.Client%2FQuery%2FDistinctMap.UnorderedDistinctMap.cs&opath=%2FProduct%2FSDK%2F.net%2FMicrosoft.Azure.Documents.Client%2FQuery%2FDistinctMap.UnorderedDistinctMap.cs&mversion=GC952ea1a412850770e417b892c25a11272fd119cb&oversion=GCec11d7d0b0246a5f3d53536f0e10d0d2ed50d0e5&_a=compare

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@j82w j82w added the QUERY label Sep 26, 2019
@j82w j82w added this to In progress in .NET v3 Board via automation Sep 26, 2019
@j82w j82w added this to In progress in Cosmos DB SDK team via automation Sep 26, 2019
@kirankumarkolli
Copy link
Member

kirankumarkolli commented Sep 26, 2019

Cosmos is schema less -> in query a single "ORDER BY " might result with different data-types for , hence the type ordering. Is my understanding right?

Is the order defined unique to Cosmos or some standard defined? (ex: Cassandra/Mongo)

Cosmos DB SDK team automation moved this from In progress to Review in progress Sep 26, 2019
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments

.NET v3 Board automation moved this from In progress to Review in progress Sep 26, 2019
@kirankumarkolli
Copy link
Member

Please create feature issues on non .NET SDK repos' for tracking.

Cosmos DB SDK team automation moved this from Review in progress to Reviewer approved Oct 11, 2019
.NET v3 Board automation moved this from Review in progress to Reviewer approved Oct 11, 2019
changelog.md Outdated Show resolved Hide resolved
Cosmos DB SDK team automation moved this from Reviewer approved to Review in progress Oct 19, 2019
.NET v3 Board automation moved this from Reviewer approved to Review in progress Oct 19, 2019
Cosmos DB SDK team automation moved this from Review in progress to Reviewer approved Oct 22, 2019
.NET v3 Board automation moved this from Review in progress to Reviewer approved Oct 22, 2019
Cosmos DB SDK team automation moved this from Reviewer approved to Review in progress Oct 23, 2019
.NET v3 Board automation moved this from Reviewer approved to Review in progress Oct 23, 2019
Cosmos DB SDK team automation moved this from Review in progress to Reviewer approved Oct 24, 2019
.NET v3 Board automation moved this from Review in progress to Reviewer approved Oct 24, 2019
@kirankumarkolli kirankumarkolli merged commit ab4f1d7 into master Oct 24, 2019
Cosmos DB SDK team automation moved this from Reviewer approved to Done Oct 24, 2019
.NET v3 Board automation moved this from Reviewer approved to Done Oct 24, 2019
@kirankumarkolli kirankumarkolli deleted the users/brchon/OrderByArrayAndObject branch October 24, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
.NET v3 Board
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants