Query ExactPage semantics #946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
reviewed
Oct 30, 2019
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosQueryExecutionContextFactory.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionComponent/SkipDocumentQueryExecutionComponent.cs
Show resolved
Hide resolved
| @@ -21,7 +21,7 @@ internal sealed class CosmosQueryExecutionContextFactory : CosmosQueryExecutionC | |||
| internal const string InternalPartitionKeyDefinitionProperty = "x-ms-query-partitionkey-definition"; | |||
| private const int PageSizeFactorForTop = 5; | |||
|
|
|||
| internal readonly CosmosQueryContext CosmosQueryContext; | |||
| public readonly CosmosQueryContext cosmosQueryContext; | |||
There was a problem hiding this comment.
Why public? The class is internal. #Resolved
There was a problem hiding this comment.
the class is internal so all the members will inherit that.
In reply to: 340572394 [](ancestors = 340572394)
There was a problem hiding this comment.
You can leave it as public, but it is easier to read if you leave it as internal. That way you don't have to go to the class to see if it public.
...soft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosParallelItemQueryExecutionContext.cs
Show resolved
Hide resolved
...soft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosParallelItemQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Nov 5, 2019
...soft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosParallelItemQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
j82w
approved these changes
Nov 5, 2019
j82w
reviewed
Nov 5, 2019
|
This PR is superceded by this one: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query Batching
Description
Batching query pages together to try and fill out the user's max item count. This is avoid some CRIs. For compute we can fork these to allow for more preemptions.
Type of change
Please delete options that are not relevant.