Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blob Trigger Error #9419

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Fix Blob Trigger Error #9419

merged 4 commits into from
Jul 27, 2023

Conversation

Tonewall
Copy link
Contributor

Fixing the issue in #9385
Http trigger apps are running into the error:
The Flex Consumption SKU only supports EventGrid as the source for BlobTrigger functions. Please update function 'SimpleHttpRequest' to use EventGrid. For more information see https://aka.ms/blob-trigger-eg.

Issue seems like the check is defaulting to true which runs for all triggers

Issue describing the changes in this PR

resolves #9386

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@Tonewall Tonewall requested a review from a team as a code owner July 25, 2023 19:43
@pragnagopa
Copy link
Member

@Tonewall - Please see unit tests added in https://github.com/Azure/azure-functions-host/pull/9385/files - increase the test converage to include:

  1. Other triggers that are not blob - EventHubTrigger
  2. HttpTrigger + Blob Input + BlobOutput

Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update tests

@CooperLink
Copy link
Contributor

Cherry-picked MyGet removal

Copy link
Member

@alrod alrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me.

Not sure why we changed the dependances in EndToEndTestFixture.cs

@Tonewall
Copy link
Contributor Author

Update tests

Added test to cover http triggers to not have the error thrown

@pragnagopa pragnagopa merged commit f416b27 into dev Jul 27, 2023
7 checks passed
@pragnagopa pragnagopa deleted the u/tonychoi/fix-blob-trigger-error branch July 27, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw error if regular blob trigger + flex
5 participants