Configure page for Application Insights #2560

nertim · 2018-04-16T22:05:49Z

Adding a configure page for Application Insights. The users can temporarily opt out of it by switching to classic view, but that setting is stored locally. The goal is to drive all users to using application insights for their logs.

Video of the scenario : https://microsoft-my.sharepoint.com/:v:/p/michinoy/ESYr0w2rXH9PjNFvePFfxkoBokcd9_u3X_vakR0sFnJs0Q?e=onlHLq

There is a delay (3 - 5 mins) in app insights getting the data:

hartra344 · 2018-04-17T04:13:31Z

client/src/app/function-monitor/function-monitor.component.ts

    }

-    shouldRenderMonitorClassic(): boolean {
+    public shouldRenderMonitorClassic(): boolean {


nit: can we make this a get function if it's just here to be used in the template code? Feels a little cleaner without () in the html #ByDesign

hartra344

hartra344 · 2018-04-17T04:15:11Z

client/src/app/function-monitor/function-monitor.component.ts

        return this._renderComponentName === ComponentNames.monitorClassic;
    }

-    shouldRenderMonitorApplicationInsights(): boolean {
+    public shouldRenderMonitorApplicationInsights(): boolean {


same here #Resolved

hartra344 · 2018-04-17T04:16:59Z

client/src/app/function-monitor/function-monitor.component.ts

+            this.functionMonitorInfo.appInsightsResourceDescriptor === null) {
+            errorEvent = {
+                errorId: errorIds.applicationInsightsInstrumentationKeyMismatch,
+                message: 'Application insights key mismatch.',


can't really tell where this is being used, but want to make sure its a logged item and not something that belongs in resources #Resolved

actually looks like it belongs in resources because you translate it in other places #Resolved

hartra344 · 2018-04-17T04:18:32Z

client/src/app/function-monitor/monitor-classic/monitor-classic.component.html

    <command displayText="{{ 'refresh' | translate }}"
        (click)="refreshMonitorClassicData()"
        iconUrl="image/reset.svg"></command>
 </command-bar>

-<div class="function-monitor-content">
+<div *ngIf = "!shouldRenderMonitorConfigure()" class="function-monitor-content">

    <div class="alert alert-warning alert-dismissible" role="alert">
        <img src="image/appInsights.svg"/>
        <span [innerHTML]="'monitoring_appInsights' | translate"></span>


I know this line isn't your code but can we please make this {{'monitoring_appInsights' | translate}}

innerHtml for this seems really wierd #Resolved

hartra344 · 2018-04-17T04:20:24Z

client/src/app/function-monitor/monitor-configure/monitor-configure.component.html

+</command-bar>
+
+<app-card-info-control
+  [image]="'image/info.svg'"


nit: image="image/info.svg" (I know this is my favorite copy/paste mistake in my own code 😛 ) #Resolved

hartra344 · 2018-04-17T04:20:47Z

client/src/app/function-monitor/monitor-configure/monitor-configure.component.scss

@@ -0,0 +1 @@
+@import '../../../sass/common/variables';


remove? #Resolved

Yeah, initially I thought I might have some custom styles.. but doesn't look like it. Will leave the file, just in case if this changes. #Resolved

hartra344 · 2018-04-17T04:22:14Z

client/src/app/shared/models/portal-resources.ts

@@ -1028,4 +1029,8 @@
    public static deploymentCenterTitle: string = "deploymentCenterTitle";
    public static deploymentCenterDesc: string = "deploymentCenterDesc";
    public static monitorHostFetchFailed: string = "monitorHostFetchFailed";
+    public static configureAppInsightsTitle: string = "configureAppInsightsTitle";


I just realized I should remove :string from this file. Any other place that would cause linting issues #Resolved

hartra344 · 2018-04-17T04:23:11Z

client/src/app/shared/services/application-insights.service.ts

-          }
-        });
+      const resultJson = response.result.json();
+      if (!!resultJson) {


maybe some commenting on what is going on here? What are element[0] and element[1]? #Resolved

hartra344 · 2018-04-17T20:16:19Z

client/src/app/shared/models/function-monitor.ts

-import { ARMApplicationInsightsDescriptior } from "../resourceDescriptors";
-import { ErrorEvent } from "./error-event";
+import { FunctionAppContext } from '../function-app-context';
+import { Dictionary } from 'lodash';


please dont import all of lodash, it's huge. I dont think Dictionary is available yet as an es6 module though. Can you use { [key:string] : string} instead? #Resolved

hartra344

ehamai · 2018-04-17T22:44:22Z

client/src/app/function-monitor/monitor-configure/monitor-configure.component.ts

+    return monitorConfigureInfoInputEvent
+      .switchMap(monitorConfigureInfo => Observable.zip(
+        Observable.of(monitorConfigureInfo),
+      ))


This switchMap isn't doing anything and you can remove it #Resolved

ehamai · 2018-04-17T22:56:23Z

export class MonitorApplicationInsightsComponent extends FeatureComponent {

You don't have the HTML file for this component in your PR, but from your video I saw the red/green text for error and successful requests. Would it be possible to show a green checkmark icon for success, and a red error icon for failure, and then make the text black? I think it may get called out by accessibility. #Resolved

Refers to: client/src/app/function-monitor/monitor-applicationinsights/monitor-applicationinsights.component.ts:18 in 3668d7e. [](commit_id = 3668d7e, deletion_comment = False)

ehamai · 2018-04-17T22:58:35Z

client/src/app/shared/services/application-insights.service.ts

-            summary.failedCount = element[1];
-          }
-        });
+      const resultJson = response.result.json();


response.result.json() [](start = 25, length = 22)

Is there a type for this? #Pending

Are you referring to creating a type to represent this? #Resolved

are you saying I should a type for this?

In reply to: 182266726 [](ancestors = 182266726)

Sorry yes. I meant that there should be a type for this instead of any

In reply to: 182514236 [](ancestors = 182514236,182266726)

ehamai · 2018-04-17T23:02:10Z

client/src/app/shared/services/local-storage.service.ts

+        }
+    }
+
+    public setFunctionMonitorClassicViewPreference(functionAppResourceId: string, value: string) {


public setFunctionMonitorClassicViewPreference(functionAppResourceId: string, value: string) { [](start = 4, length = 94)

Can you add these to the application-insights.service? This service should mainly only be used for handling communication to local storage. #Resolved

good point. #Resolved

ehamai · 2018-04-17T23:04:41Z

client/src/app/shared/services/broadcast.service.ts

@@ -170,7 +174,8 @@ export class BroadcastService {
            case BroadcastEvent.ClearError:
                return this.clearErrorEvent;

-
+            case BroadcastEvent.RefreshMonitoringView:
+                return this.refreshMonitorEvent;


This isn't required if you're using broadcastEvent and getEvent methods. #Resolved

ehamai

🕐

nertim · 2018-04-18T17:51:14Z

export class MonitorApplicationInsightsComponent extends FeatureComponent {

I have created a separate issue to just go through all the new experience and make sure accessiblity is properly addressed. I will add this to that issue and send out a separate PR.

In reply to: 382182873 [](ancestors = 382182873)

Refers to: client/src/app/function-monitor/monitor-applicationinsights/monitor-applicationinsights.component.ts:18 in 3668d7e. [](commit_id = 3668d7e, deletion_comment = False)

nertim · 2018-04-18T17:53:05Z

export class MonitorApplicationInsightsComponent extends FeatureComponent {

https://app.zenhub.com/workspace/o/azure/azure-functions-ux/issues/2574

In reply to: 382472917 [](ancestors = 382472917,382182873)

Refers to: client/src/app/function-monitor/monitor-applicationinsights/monitor-applicationinsights.component.ts:18 in 3668d7e. [](commit_id = 3668d7e, deletion_comment = False)

ehamai

* Introduce application insights based monitoring view (#2516) Introduce application insights based monitoring view and do a little of refactor on the existing monitoring view. * Redoing the extension cache fix (#2555) * [SpecPicker] Adding individual banner to each group. Also several other bug fixes (#2552) * Removing AzureFunctions.AngularClient folder * Pass context for create (#2559) * Initial upload experience for Prod Functions (#2557) * Hotfix for set model after token loads (#2562) (#2563) * Hotfix for set model after token loads * update v1 version number * adding top level tslint for codacy * adjusting linting rules for codacy * adding azure-cli script for swapping ux slots (#2568) * add control with placeholder logic * add lodash to blacklisted imports (#2572) * update setting values * adding moment to blacklist as well (#2573) * updating production slot swap to fix a couple of bugs * update resources * Add metrics feature to monitoring section (#2578) Add metrics feature link to monitoring page. * Fixes #2480 - Add accessibility support to spec picker (#2575) * Fixes #2480 - Add accessibility to spec picker * Updated from PR comments * Add ~2 to list of stable runtimes. Closes #2564 * Set readOnly state for prod dynmic linux. Closes #2565 * Configure page for Application Insights (#2560) monitor configure page * update check scenario * Fix slot locks * Update name of site config property * poll function logs if the app is dynamic linux. Closes #2571 * Update id check (#2588) * PR updates * Wait on existing polling request if it takes longer than 2 seconds. * more pr updates * remove console log * Add separate list for recommended skus and add resources for strings (#2585) * Add separate list for recommended skus and add resources for strings * Removing duplicate identifier * Updated from feedback * updated feedback * hide behind feature flag * Inject build number to package.json and an api * Collect perf counters from backend * Add build defintion * as per discussion with elliot prepending 1.0. to the build number for version number * fixing issue where server won't run locally due to invalid package version * make server file pull version from package.json * update axios to 0.18 * set keepAlive to true for proxied connections * Fix issue where UI doesn't handle scaling an isolated SKU. Plus other bug fixes (#2599) * Fix issue where UI doesn't handle scaling an isolated SKU. Plus other bug fixes * Remove shield but disable apply button when isolated scale operation in progress * Updated from PR feedback * Updated links and changed wording on ACU language * Add global mocks for log and telemetry service (#2601) Add global mocks for log and telemetry service * Fix initial items Alex found. (#2598) * prefix class name (#2602) * Add dark theme to spec picker. Closes #2481 (#2604) * Removing feature flag and enabling new spec picker by default (#2605) * Removing feature flag and enabling new spec picker by default * remove url import * CICD polish (#2609) * Changing auth token to be passed through body of passthrough rather t… (#2618) * Changing auth token to be passed through body of passthrough rather than header * Codacy * Update the scenario status for all environments for AI based monitoring. (#2615) Update the scenario status for all environments for AI based monitoring. * Spec picker bugs for styling and xenon (#2630) * Spec picker bugs for styling and xenon * PR feedback * More styling, fwdlinks, and spec clean up - Fixes #2627, Fixes #2612, Fixes #2628 (#2632) * Add support for linux pricing (#2635) * Fix up some acessibility items and dark theme items. (#2634) * Inject empty headers to urls going to our backend, not using arm headers (#2636) * Inject empty headers to urls going to our backend, not using arm headers * Codacy * Add busy state when opening create sidebar (#2633) * add busy state when opening create sidebar * use busy manager * remove underscore * Handle busy error (#2637) * Changing desgin of cards for source and build providers (#2639) * Changing desgin of cards for source and build providers * udpating strings * PR Comments * changing settings to not show runtime info if compose or kubernetes i… (#2640) * changing settings to not show runtime info if compose or kubernetes is used * PR Comment * KUBE| * Make the datetime more granular and add sorting capability. (#2647) * Adding diagnose and solve problems (#2641) * Adding diagnose and solve problems * Removing RBAC check * Sort app settings by name (#2648) * Use resources for FTP/S options (#2650) * Fix the table styling, delay message, and linux function configuration page (#2649) Fix the table styling, delay message, and linux function configuration page. * Update extension install message (#2651) * update extension install message * + is * Add a close button on top right. This aligns with some of the other slide outs with the close buttons. (#2652) * Add a close button on top right. This aligns with some of the other slide outs with the close buttons. * Change to Subject() * Move application insights link to essentials col (#2653) * Move application insights link to essentials col Indicate number of results returned in query and provide a link to open in the AI query editor. * PR Comments. * Fixing issue where S2 and S3 are not available for Linux (#2655) * Fixing issue where S2 and S3 are not available for Linux * Removing kinds reference * String change for AI configuration instructions. (#2656) * Remove FTP feature flag (#2657) * Hardcoding Linux Pv2 regions until the georegions API works properly (#2658) * Fix read\write -> read/write. Closes #2507 (#2659) * Adding discount banner for existing linux isolated group in spec picker (#2660) * Updating MSI title to preview * Updating resource strings

monitor configure page

d0f0241

hartra344 reviewed Apr 17, 2018

View reviewed changes

hartra344 requested changes Apr 17, 2018

View reviewed changes

nertim added 3 commits April 17, 2018 10:39

Merge branch 'dev' into michinoy-monitor-configure

4d81272

PR comments

8c82631

make codacy happy :)

279b8fd

Azure deleted a comment Apr 17, 2018

hartra344 reviewed Apr 17, 2018

View reviewed changes

remove loash

3668d7e

hartra344 approved these changes Apr 17, 2018

View reviewed changes

nertim requested review from ahmelsayed, ehamai and ammanifold April 17, 2018 21:55

ehamai reviewed Apr 17, 2018

View reviewed changes

ehamai requested changes Apr 17, 2018

View reviewed changes

PR Comments.

2826563

ehamai approved these changes Apr 18, 2018

View reviewed changes

nertim added 2 commits April 18, 2018 13:38

Merge branch 'dev' into michinoy-monitor-configure

f935e2b

strongly type the AI query results.

dec275d

nertim merged commit 41ac42c into dev Apr 18, 2018

nertim deleted the michinoy-monitor-configure branch April 18, 2018 23:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configure page for Application Insights #2560

Configure page for Application Insights #2560

nertim commented Apr 16, 2018

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 left a comment

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

nertim Apr 17, 2018 •

edited

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 left a comment

ehamai Apr 17, 2018 •

edited by nertim

ehamai commented Apr 17, 2018 •

edited by nertim

ehamai Apr 17, 2018 •

edited by nertim

nertim Apr 18, 2018 •

edited

nertim Apr 18, 2018

ehamai Apr 18, 2018

ehamai Apr 17, 2018 •

edited by nertim

nertim Apr 18, 2018 •

edited

ehamai Apr 17, 2018 •

edited by nertim

ehamai left a comment

nertim commented Apr 18, 2018

nertim commented Apr 18, 2018

ehamai left a comment

Configure page for Application Insights #2560

Configure page for Application Insights #2560

Conversation

nertim commented Apr 16, 2018

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 left a comment

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

nertim Apr 17, 2018 • edited

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

hartra344 left a comment

Choose a reason for hiding this comment

ehamai Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

ehamai commented Apr 17, 2018 • edited by nertim

ehamai Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

nertim Apr 18, 2018 • edited

Choose a reason for hiding this comment

nertim Apr 18, 2018

Choose a reason for hiding this comment

ehamai Apr 18, 2018

Choose a reason for hiding this comment

ehamai Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

nertim Apr 18, 2018 • edited

Choose a reason for hiding this comment

ehamai Apr 17, 2018 • edited by nertim

Choose a reason for hiding this comment

ehamai left a comment

Choose a reason for hiding this comment

nertim commented Apr 18, 2018

nertim commented Apr 18, 2018

ehamai left a comment

Choose a reason for hiding this comment

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

nertim Apr 17, 2018 •

edited

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

hartra344 Apr 17, 2018 •

edited by nertim

ehamai Apr 17, 2018 •

edited by nertim

ehamai commented Apr 17, 2018 •

edited by nertim

ehamai Apr 17, 2018 •

edited by nertim

nertim Apr 18, 2018 •

edited

ehamai Apr 17, 2018 •

edited by nertim

nertim Apr 18, 2018 •

edited

ehamai Apr 17, 2018 •

edited by nertim