-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lodash to blacklisted imports #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammanifold
approved these changes
Apr 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nertim
approved these changes
Apr 17, 2018
ehamai
added a commit
that referenced
this pull request
May 4, 2018
* Introduce application insights based monitoring view (#2516) Introduce application insights based monitoring view and do a little of refactor on the existing monitoring view. * Redoing the extension cache fix (#2555) * [SpecPicker] Adding individual banner to each group. Also several other bug fixes (#2552) * Removing AzureFunctions.AngularClient folder * Pass context for create (#2559) * Initial upload experience for Prod Functions (#2557) * Hotfix for set model after token loads (#2562) (#2563) * Hotfix for set model after token loads * update v1 version number * adding top level tslint for codacy * adjusting linting rules for codacy * adding azure-cli script for swapping ux slots (#2568) * add control with placeholder logic * add lodash to blacklisted imports (#2572) * update setting values * adding moment to blacklist as well (#2573) * updating production slot swap to fix a couple of bugs * update resources * Add metrics feature to monitoring section (#2578) Add metrics feature link to monitoring page. * Fixes #2480 - Add accessibility support to spec picker (#2575) * Fixes #2480 - Add accessibility to spec picker * Updated from PR comments * Add ~2 to list of stable runtimes. Closes #2564 * Set readOnly state for prod dynmic linux. Closes #2565 * Configure page for Application Insights (#2560) monitor configure page * update check scenario * Fix slot locks * Update name of site config property * poll function logs if the app is dynamic linux. Closes #2571 * Update id check (#2588) * PR updates * Wait on existing polling request if it takes longer than 2 seconds. * more pr updates * remove console log * Add separate list for recommended skus and add resources for strings (#2585) * Add separate list for recommended skus and add resources for strings * Removing duplicate identifier * Updated from feedback * updated feedback * hide behind feature flag * Inject build number to package.json and an api * Collect perf counters from backend * Add build defintion * as per discussion with elliot prepending 1.0. to the build number for version number * fixing issue where server won't run locally due to invalid package version * make server file pull version from package.json * update axios to 0.18 * set keepAlive to true for proxied connections * Fix issue where UI doesn't handle scaling an isolated SKU. Plus other bug fixes (#2599) * Fix issue where UI doesn't handle scaling an isolated SKU. Plus other bug fixes * Remove shield but disable apply button when isolated scale operation in progress * Updated from PR feedback * Updated links and changed wording on ACU language * Add global mocks for log and telemetry service (#2601) Add global mocks for log and telemetry service * Fix initial items Alex found. (#2598) * prefix class name (#2602) * Add dark theme to spec picker. Closes #2481 (#2604) * Removing feature flag and enabling new spec picker by default (#2605) * Removing feature flag and enabling new spec picker by default * remove url import * CICD polish (#2609) * Changing auth token to be passed through body of passthrough rather t… (#2618) * Changing auth token to be passed through body of passthrough rather than header * Codacy * Update the scenario status for all environments for AI based monitoring. (#2615) Update the scenario status for all environments for AI based monitoring. * Spec picker bugs for styling and xenon (#2630) * Spec picker bugs for styling and xenon * PR feedback * More styling, fwdlinks, and spec clean up - Fixes #2627, Fixes #2612, Fixes #2628 (#2632) * Add support for linux pricing (#2635) * Fix up some acessibility items and dark theme items. (#2634) * Inject empty headers to urls going to our backend, not using arm headers (#2636) * Inject empty headers to urls going to our backend, not using arm headers * Codacy * Add busy state when opening create sidebar (#2633) * add busy state when opening create sidebar * use busy manager * remove underscore * Handle busy error (#2637) * Changing desgin of cards for source and build providers (#2639) * Changing desgin of cards for source and build providers * udpating strings * PR Comments * changing settings to not show runtime info if compose or kubernetes i… (#2640) * changing settings to not show runtime info if compose or kubernetes is used * PR Comment * KUBE| * Make the datetime more granular and add sorting capability. (#2647) * Adding diagnose and solve problems (#2641) * Adding diagnose and solve problems * Removing RBAC check * Sort app settings by name (#2648) * Use resources for FTP/S options (#2650) * Fix the table styling, delay message, and linux function configuration page (#2649) Fix the table styling, delay message, and linux function configuration page. * Update extension install message (#2651) * update extension install message * + is * Add a close button on top right. This aligns with some of the other slide outs with the close buttons. (#2652) * Add a close button on top right. This aligns with some of the other slide outs with the close buttons. * Change to Subject() * Move application insights link to essentials col (#2653) * Move application insights link to essentials col Indicate number of results returned in query and provide a link to open in the AI query editor. * PR Comments. * Fixing issue where S2 and S3 are not available for Linux (#2655) * Fixing issue where S2 and S3 are not available for Linux * Removing kinds reference * String change for AI configuration instructions. (#2656) * Remove FTP feature flag (#2657) * Hardcoding Linux Pv2 regions until the georegions API works properly (#2658) * Fix read\write -> read/write. Closes #2507 (#2659) * Adding discount banner for existing linux isolated group in spec picker (#2660) * Updating MSI title to preview * Updating resource strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it blocked by codacy