Move deployment center to use table with proper sorting/grouping #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartra344
commented
Sep 27, 2018
| setTimeout(() => { | ||
| this.appTable.groupItems('date', 'desc'); | ||
| }, 0); | ||
| // setTimeout(() => { |
ammanifold
reviewed
Sep 27, 2018
| </ng-template> | ||
| </ngx-datatable-column> | ||
| </ngx-datatable> | ||
| <!-- <tbl [items]="TableItems" #table="tbl" id="activity-list" [name]="'functionApps' | translate" groupColName="message"> |
ammanifold
reviewed
Sep 27, 2018
| <ngx-datatable-column name="{{'logs' | translate}}" prop="" editable="false" [resizeable]="true" [flexGrow]="1"> | ||
| <ng-template ngx-datatable-cell-template let-rowIndex="rowIndex" let-value="value" let-row="row" | ||
| let-group="group"> | ||
| <span [load-image]="'image/generic-template.svg'" class="command-icon" (click)="details(row)" role="button" (keyup)="onLogsKeyUp($event.target.value, row)"></span> |
There was a problem hiding this comment.
i think it would look cleaner if we did 1 attribute per line
ammanifold
reviewed
Sep 27, 2018
| <ng-sidebar #sidebar [(opened)]="sidePanelOpened" [mode]="'over'" [position]="'right'" [closeOnClickOutside]="true" [trapFocus]="false" | ||
| [autoFocus]="true" [sidebarClass]="'sidebar'" [ariaLabel]="'Deployment Details'" [animate]="true" [showBackdrop]="true"> | ||
| <ng-sidebar #sidebar *ngIf="sidePanelOpened" [(opened)]="sidePanelOpened" [mode]="'over'" [position]="'right'" [closeOnClickOutside]="true" [trapFocus]="false" | ||
| [autoFocus]="true" [sidebarClass]="'sidebar'" [ariaLabel]="'deploymentDetails'| translate" [animate]="true" [showBackdrop]="true"> |
There was a problem hiding this comment.
same with the sidebar :)
hartra344
added a commit
that referenced
this pull request
Sep 28, 2018
* fix the kubernetes samples spacing (#3218) * Update read-only check for run from package (#3221) * Quickstart: more templates option (#3223) * initial logic * add resources * can get to quickstart from templates page * variable updates * codacy * Removing diagnostic logs from Function apps (#3226) * Fix issue where source control always shows loading if auth token is given but invalid (#3227) * New Event Grid create blade (#3233) * update blade name * update name * Deployment Center for linux web apps (#3112) * Initial work to support linux vsts deployments * linux deploymentcenterwork * Framework Versions * cahnges * linuxwork * squash * fixing PR comments * PR comments * Add Semicolons * fixed failing tests * portal resources * fix rxjs direct import * PR Comments * PR COmments * Downgrade to V1 scenario (#3232) * remove worker runtime on downgrade, ignore worker runtime if v1 * add success check for app settings update * throw error * Add ability to sync with VSTS build dashboard (#3229) * Add ability to sync with VSTS build dashboard * codacy * SQUASH * Extension styling (#3222) * installation styling * Resource update * switch h4s to divs * Break-word in error boxes (#3235) * Fix typo in resource key functionNew_functionExists (#3228) * Fix resource key * Update autogenerated portal-resources.ts * Fix style of side bar flyout to be consistant with fluent design (#3236) * Fix style of side bar flyout to be consistant with fluent design * small typo fix * squash * Update single container and multicontainer samples (#3238) * Update single container and multicontainer samples * add a note indicating api usage in the future. * address PR Comments * Introducing PremiumElastic SKU * Move deployment center to use table with proper sorting/grouping (#3241) * Move deployment center to use table with proper sorting/grouping * PR Comment * remove commented table * multiline sidebar * Deployment Cetner GA Accessability work items (#3239) * Add rols to copy-pre buttons * Keyboard navigation for FTP * use correct labeling in form elements for deployment center * add error message bindning * add alt text to images * Revert "add alt text to images" This reverts commit f151d39. * alt text for card images * Alt text for FTP image * New FTP color for accessability * roles and aria for card selection controls * Keyboard navigation for source and build step cards * Add keyboard bindings for copy-pre * remove preview from vsts for now * fixing function call * squash * div -> label * Add radio control for masking/displaying app setting and connection string values * Move extension install logic to base component (#3245) * move extension install logic to base component * pr updates * remove extra deploymentDetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.