Move extension install logic to base component #3245
Conversation
| <i class="fa fa-warning"></i> {{nugetPackage.id}} | ||
| </div> | ||
| </div> | ||
| <div class="panel-footer"> | ||
| <a class="link left" (click)="installRequiredExtensions()"> | ||
| <a class="link left" (click)="takeHostOffline()"> |
There was a problem hiding this comment.
takeHostOffline [](start = 46, length = 15)
This changed from installing extensions, to taking the host offline. Is that equivalent? #Resolved
There was a problem hiding this comment.
Yup :). That's now the first step of the process with the new APIs
In reply to: 221088702 [](ancestors = 221088702)
There was a problem hiding this comment.
But where in that function does it actually do anything related to installing? I only see code to take it offline.
In reply to: 221089285 [](ancestors = 221089285,221088702)
There was a problem hiding this comment.
ACtually never mind. I see the call to pollHostStatus. takeHostOffline is a bit of a misleading name though. Can you change it back to installExtensions maybe?
In reply to: 221089939 [](ancestors = 221089939,221089285,221088702)
There was a problem hiding this comment.
Once it's taken offline it's called to updateExtensions
In reply to: 221089939 [](ancestors = 221089939,221089285,221088702)
There was a problem hiding this comment.
There was a problem hiding this comment.
Although I think it's best to have that call into the takeHostOffline function
In reply to: 221090757 [](ancestors = 221090757,221090456,221089939,221089285,221088702)
* fix the kubernetes samples spacing (#3218) * Update read-only check for run from package (#3221) * Quickstart: more templates option (#3223) * initial logic * add resources * can get to quickstart from templates page * variable updates * codacy * Removing diagnostic logs from Function apps (#3226) * Fix issue where source control always shows loading if auth token is given but invalid (#3227) * New Event Grid create blade (#3233) * update blade name * update name * Deployment Center for linux web apps (#3112) * Initial work to support linux vsts deployments * linux deploymentcenterwork * Framework Versions * cahnges * linuxwork * squash * fixing PR comments * PR comments * Add Semicolons * fixed failing tests * portal resources * fix rxjs direct import * PR Comments * PR COmments * Downgrade to V1 scenario (#3232) * remove worker runtime on downgrade, ignore worker runtime if v1 * add success check for app settings update * throw error * Add ability to sync with VSTS build dashboard (#3229) * Add ability to sync with VSTS build dashboard * codacy * SQUASH * Extension styling (#3222) * installation styling * Resource update * switch h4s to divs * Break-word in error boxes (#3235) * Fix typo in resource key functionNew_functionExists (#3228) * Fix resource key * Update autogenerated portal-resources.ts * Fix style of side bar flyout to be consistant with fluent design (#3236) * Fix style of side bar flyout to be consistant with fluent design * small typo fix * squash * Update single container and multicontainer samples (#3238) * Update single container and multicontainer samples * add a note indicating api usage in the future. * address PR Comments * Introducing PremiumElastic SKU * Move deployment center to use table with proper sorting/grouping (#3241) * Move deployment center to use table with proper sorting/grouping * PR Comment * remove commented table * multiline sidebar * Deployment Cetner GA Accessability work items (#3239) * Add rols to copy-pre buttons * Keyboard navigation for FTP * use correct labeling in form elements for deployment center * add error message bindning * add alt text to images * Revert "add alt text to images" This reverts commit f151d39. * alt text for card images * Alt text for FTP image * New FTP color for accessability * roles and aria for card selection controls * Keyboard navigation for source and build step cards * Add keyboard bindings for copy-pre * remove preview from vsts for now * fixing function call * squash * div -> label * Add radio control for masking/displaying app setting and connection string values * Move extension install logic to base component (#3245) * move extension install logic to base component * pr updates * remove extra deploymentDetails
fixes #3237