New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge latest from main #2895
Merged
Merged
merge latest from main #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replaced custom methods with string methods * test patch
* Retain the delay after some faults that are thought to be hub-wide * Fix logical error * Make test long running and code cleanup * Get ambiguity error for this test on Linux netcore 3.1 * Fix timing issue in registry manager test
* added samples to one sln * deleted extra sln file * combined folders in WSL * removed programs from sln causing test to crash * more tweaks to sln * update links in readme
* added projects to main sln file * provisioning device samples added to main sln * provisioning service samples added to main sln * deleted extra sln files
…than wrap another retry policy around method calls (#2827) * Update the reconnection sample to use the retry policy fully, rather than wrap another retry policy around method calls * CR feedback
- Removed an unused parameter and enum - Update instructions
#2881 but for main this time
drwill-ms
force-pushed
the
drwill/merge-main
branch
from
October 19, 2022 20:54
b570148
to
1518258
Compare
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
October 19, 2022 20:56
drwill-ms
commented
Oct 19, 2022
provisioning/device/samples/Getting Started/ComputeDerivedSymmetricKeySample/Parameters.cs
Show resolved
Hide resolved
timtay-microsoft
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to merge without squashing
drwill-ms
commented
Oct 19, 2022
drwill-ms
commented
Oct 19, 2022
brycewang-microsoft
approved these changes
Oct 19, 2022
patilsnr
approved these changes
Oct 19, 2022
provisioning/device/samples/Getting Started/ComputeDerivedSymmetricKeySample/Parameters.cs
Show resolved
Hide resolved
abhipsaMisra
approved these changes
Oct 19, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.