Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting about MAX_RETRY_SECONDS #37

Open
sushaanttb opened this issue Feb 21, 2024 · 2 comments
Open

Documenting about MAX_RETRY_SECONDS #37

sushaanttb opened this issue Feb 21, 2024 · 2 comments

Comments

@sushaanttb
Copy link
Contributor

sushaanttb commented Feb 21, 2024

MAX_RETRY_SECONDS is also an important constant in the code for specifying the duration to stop the throttling retries.
However, there's no mention about same in the documentation.

Ideally, it should also be mentioned about in the documentation so that the user is aware about it.
The documentation should talk about the reason for keeping this current hardcoded value of 5s & it's usage (for e.g. in retry logic and backoff logic) etc.

Relates to - #36

@michaeltremeer
Copy link
Contributor

I am copy-pasting my response from your other issue for anyone else who reads this issue:

Hey @sushaanttb,

Have a look at #21 and the discussion within. You will see some more info there about what is going on with different retry settings, and how MAX_RETRY_SECONDS effects the outputs. That PR has not been merged and it doesn't look like it will, so if you want the behaviour you suggest, I would suggest you use my fork which fixes this issue and uses a more suitable value of 60 seconds for MAX_RETRY_SECONDS.

@sushaanttb
Copy link
Contributor Author

Hi @michaeltremeer,

Thanks for the comment, I have covered about same in my comment here:
#38 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants