Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HybridConnectionUtil does not handle requests having empty query string param #66

Open
piotrnk opened this issue Mar 12, 2020 · 3 comments · Fixed by #67
Open

HybridConnectionUtil does not handle requests having empty query string param #66

piotrnk opened this issue Mar 12, 2020 · 3 comments · Fixed by #67
Assignees
Labels

Comments

@piotrnk
Copy link

piotrnk commented Mar 12, 2020

example requests:
/host/request?param
/host/request?param=

@piotrnk
Copy link
Author

piotrnk commented Mar 12, 2020

quick fix would be to skip throwing exception and just set an empty value on line 143:

if (keyValue.length != 2) {
        map.put(keyValue[0], "");
} else {
        map.put(keyValue[0], keyValue[1]);
}

@dlstucki
Copy link
Contributor

To clarify, you're referring to URI query string parameters, right?

@piotrnk piotrnk changed the title HybridConnectionUtil does not handle requests having empty path params HybridConnectionUtil does not handle requests having empty query string param Mar 13, 2020
@jfggdl jfggdl closed this as completed Jun 9, 2020
@jfggdl jfggdl reopened this Jun 9, 2020
@jfggdl jfggdl linked a pull request Jun 9, 2020 that will close this issue
@jfggdl
Copy link

jfggdl commented Jun 9, 2020

Closed by the pull request that has been merged. We will make available this fix in our next release.

@dlstucki dlstucki added the Relay label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants