Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotificationHubs Namespace NamespaceType not Returned in Response #17277

Open
myc2h6o opened this issue Jan 7, 2022 · 4 comments
Open

NotificationHubs Namespace NamespaceType not Returned in Response #17277

myc2h6o opened this issue Jan 7, 2022 · 4 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Notification Hub question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@myc2h6o
Copy link

myc2h6o commented Jan 7, 2022

Hi, the namespaceType property in notificationhubs namespace seems to be missing starting from some time around 2021/12/06.

"namespaceType": {
"type": "string",
"description": "The namespace type.",
"enum": [
"Messaging",
"NotificationHub"
],

The test we ran at 2021/12/03 still had it in the response.

Test I've made today using REST API (sensitive info removed):
I tried setting namespaceType to Messaging and NotificationHub, both are not shown in the GET response.

PUT https://management.azure.com/subscriptions/<sub_id>/resourceGroups/<rg>/providers/Microsoft.NotificationHubs/namespaces/<name>?api-version=2017-04-01
{
    "sku": {
        "name": "Free"
    },
    "properties": {
        "enabled": true,
        "namespaceType":"Messaging"
    },
    "location": "East US",
    "tags": {
        "env": "Test"
    }
}

GET response body:
{
    "sku": {
        "name": "Free"
    },
    "properties": {
        "provisioningState": "Succeeded",
        "status": "Active",
        "createdAt": "2022-01-07T02:46:28.9200000Z",
        "updatedAt": "2022-01-07T02:46:28.9270000Z",
        "serviceBusEndpoint": "https://yicma-hub-namespace.servicebus.windows.net:443/",
        "enabled": true,
        "critical": false,
        "zoneRedundant": false
    },
    "id": "/subscriptions/<sub_id>/resourceGroups/<rg>/providers/Microsoft.NotificationHubs/namespaces/<name>",
    "name": "<name>",
    "type": "Microsoft.NotificationHubs/namespaces",
    "location": "East US",
    "tags": {
        "env": "Test"
    }
}
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 7, 2022
@JackTn JackTn added Notification Hub Service Attention Workflow: This issue is responsible by Azure service team. labels Jan 7, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 7, 2022
@ghost
Copy link

ghost commented Jan 7, 2022

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @tjsomasundaram.

Issue Details

Hi, the namespaceType property in notificationhubs namespace seems to be missing starting from some time around 2021/12/06.

"namespaceType": {
"type": "string",
"description": "The namespace type.",
"enum": [
"Messaging",
"NotificationHub"
],

The test we ran at 2021/12/03 still had it in the response.

Test I've made today using REST API (sensitive info removed):
I tried setting namespaceType to Messaging and NotificationHub, both are not shown in the GET response.

PUT https://management.azure.com/subscriptions/<sub_id>/resourceGroups/<rg>/providers/Microsoft.NotificationHubs/namespaces/<name>?api-version=2017-04-01
{
    "sku": {
        "name": "Free"
    },
    "properties": {
        "enabled": true,
        "namespaceType":"Messaging"
    },
    "location": "East US",
    "tags": {
        "env": "Test"
    }
}

GET response body:
{
    "sku": {
        "name": "Free"
    },
    "properties": {
        "provisioningState": "Succeeded",
        "status": "Active",
        "createdAt": "2022-01-07T02:46:28.9200000Z",
        "updatedAt": "2022-01-07T02:46:28.9270000Z",
        "serviceBusEndpoint": "https://yicma-hub-namespace.servicebus.windows.net:443/",
        "enabled": true,
        "critical": false,
        "zoneRedundant": false
    },
    "id": "/subscriptions/<sub_id>/resourceGroups/<rg>/providers/Microsoft.NotificationHubs/namespaces/<name>",
    "name": "<name>",
    "type": "Microsoft.NotificationHubs/namespaces",
    "location": "East US",
    "tags": {
        "env": "Test"
    }
}
Author: myc2h6o
Assignees: -
Labels:

question, Notification Hub, Service Attention, customer-reported, needs-triage

Milestone: -

@myc2h6o
Copy link
Author

myc2h6o commented Jan 11, 2022

Issue reported on Terraform hashicorp/terraform-provider-azurerm#14541

@chrisnelson
Copy link

Any update on a timeline for this fix? Using Terraform results in always updating this resource due to this missing property which always adds 2-3 minutes to our deployments unnecessarily. Much appreciated on any updates. Thanks!

@HaroldH76
Copy link

We had the same issue and solved it by excluding the namespace_type from updates:

resource "azurerm_notification_hub_namespace" "myhub" {
  name                = "myhub-notification-hub-${var.environment}"
  resource_group_name = azurerm_resource_group.workspace_product.name
  location            = azurerm_resource_group.workspace_product.location
  namespace_type      = "NotificationHub"

  sku_name = var.notification_hub_sku

  lifecycle {
      ignore_changes = [
        # ignore namespace_type because of a bug in Azure: https://github.com/Azure/azure-rest-api-specs/issues/17277
        namespace_type
      ]
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Notification Hub question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants