Nithin/action group webhooks with azure active directory integration #6218

nithinpnp · 2019-06-04T22:32:13Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…e directory integration

…are in the response

openapi-sdkautomation · 2019-06-04T22:32:15Z

SDK Automation [Logs] (Generated from 1dca2b0)

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/monitor/azure-mgmt-monitor [Logs] [Instructions]
- azure-mgmt-monitor-0.6.0.zip
- azure_mgmt_monitor-0.6.0-py2.py3-none-any.whl

Java: Azure/azure-sdk-for-java [Logs] [Diff]

No packages generated.

Go: Azure/azure-sdk-for-go [Logs]

No packages generated.

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-monitor [Logs] [Instructions]
- azure-arm-monitor-5.4.0.tgz

Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.26.0.gem
data/monitor [Logs]

AutorestCI · 2019-06-04T22:33:23Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5914

AutorestCI · 2019-06-04T22:33:36Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2993

AutorestCI · 2019-06-04T22:33:48Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2640

AutorestCI · 2019-06-04T22:34:45Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3892

AutorestCI · 2019-06-04T22:42:42Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5039

azuresdkci · 2019-06-04T22:47:36Z

Can one of the admins verify this patch?

nithinpnp · 2019-06-04T22:58:30Z

spell check error is because of specification\mediaservices\resource-manager\Microsoft.Media\stable\2018-07-01\Encoding.json file row 1200 column 95 "specified" is there. This spelling is wrong. This the reason for the failure. We don't own this resource. pls advice

nschonni · 2019-06-05T04:27:11Z

The spelling issue will be fixed in #6145, sorry for the noise

nithinpnp · 2019-06-05T17:05:45Z

@NelsonDaniel . Could you please review this pull request ?

NelsonDaniel

Looks good to me. But, requesting ARM feedback since 4 properties were added in Model "WebhookReceiver"

nithinpnp · 2019-06-07T21:56:45Z

I noticed that person who reviewed #WaitForArmFeedback in an earlier pull request had requested previous API version for easy diff. I am new to the team hence did not add that in the earlier commit message. The prior API version is 2019-03-01. This set of changes is for 2019-06-01.

nithinpnp · 2019-06-10T17:28:11Z

@ravbhatnagar , @KrisBash .. could you please review this ?

NelsonDaniel

LGTM but still waiting for ARM feedback. I will be OOF. I am adding the Reasign label in case this needs to be merged before I am back

nithinpnp · 2019-06-13T17:40:05Z

@shahabhijeet Could you please review ?

shahabhijeet

if ActionGroup_API.json is the new API of your REST spec, would be great if you can add a commit that shows the delta of what got changed in the new API version.
If the only thing that changed is the API version, please provide a detailed description of your PR.
Also we need ARM signOff as this is a new API version.
Having a commit that shows the diff also helps ARM to quickly review your new REST spec.

...fication/monitor/resource-manager/Microsoft.Insights/stable/2019-06-01/actionGroups_API.json

majastrz · 2019-06-17T20:14:59Z

...fication/monitor/resource-manager/Microsoft.Insights/stable/2019-06-01/actionGroups_API.json

+                }
+            },
+            "patch": {
+                "description": "Updates an existing action group's tags. To update other fields use the CreateOrUpdate method.",


CreateOrUpdate [](start = 104, length = 14)

Does the PUT of actionGroup allow partial resource body? In other words, does it act like PATCH?

majastrz · 2019-06-17T20:16:40Z

...fication/monitor/resource-manager/Microsoft.Insights/stable/2019-06-01/actionGroups_API.json

+                    }
+                },
+                "x-ms-pageable": {
+                    "nextLinkName": null


null [](start = 36, length = 4)

You should set this to "nextLink" even if your service only returns 1 page. Doing so will make adding paging easier for you in the future.

majastrz · 2019-06-17T20:16:57Z

...fication/monitor/resource-manager/Microsoft.Insights/stable/2019-06-01/actionGroups_API.json

+                    }
+                },
+                "x-ms-pageable": {
+                    "nextLinkName": null


null [](start = 36, length = 4)

I'd set this to "nextLink" here too even if the service only returns 1 page.

majastrz

The incremental changes on top of 2019-03-01 look good. I added some comments that you should consider taking, but they are not blocking.

nithinpnp · 2019-06-17T21:49:39Z

@shahabhijeet Could you please review. Please note ARM team has signed off

nithinpnp added 2 commits June 4, 2019 14:28

updating the swagger doc for action webhook recivers with azure activ…

b3d1e8b

…e directory integration

1)fixed the api version 2)updated with emoty array when no recievers …

c607d81

…are in the response

azuresdkci assigned NelsonDaniel Jun 4, 2019

azuresdkci requested a review from NelsonDaniel June 4, 2019 22:32

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR monitor/resource-manager] Nithin/action group webhooks with azure active directory integration Azure/azure-sdk-for-python#5684

Merged

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR monitor/resource-manager] Nithin/action group webhooks with azure active directory integration Azure/azure-sdk-for-ruby#2540

Closed

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR monitor/resource-manager] Nithin/action group webhooks with azure active directory integration Azure/azure-sdk-for-js#3451

Closed

fixing the read me with references to 2019-06-01 version

1dca2b0

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR monitor/resource-manager] Nithin/action group webhooks with azure active directory integration Azure/azure-sdk-for-go#4955

Merged

NelsonDaniel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 7, 2019

NelsonDaniel reviewed Jun 7, 2019

View reviewed changes

NelsonDaniel approved these changes Jun 12, 2019

View reviewed changes

NelsonDaniel added the Reassign label Jun 12, 2019

azuresdkci removed the Reassign label Jun 12, 2019

azuresdkci assigned shahabhijeet and unassigned NelsonDaniel Jun 12, 2019

azuresdkci requested a review from shahabhijeet June 12, 2019 21:38

shahabhijeet requested changes Jun 13, 2019

View reviewed changes

...fication/monitor/resource-manager/Microsoft.Insights/stable/2019-06-01/actionGroups_API.json Show resolved Hide resolved

majastrz reviewed Jun 17, 2019

View reviewed changes

majastrz approved these changes Jun 17, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 17, 2019

shahabhijeet approved these changes Jun 18, 2019

View reviewed changes

shahabhijeet merged commit 94ba84b into Azure:master Jun 18, 2019

nithinpnp mentioned this pull request Jun 26, 2019

Nithin/sdkupdates 2019 06 version Azure/azure-sdk-for-net#6645

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nithin/action group webhooks with azure active directory integration #6218

Nithin/action group webhooks with azure active directory integration #6218

nithinpnp commented Jun 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

azuresdkci commented Jun 4, 2019

nithinpnp commented Jun 4, 2019

nschonni commented Jun 5, 2019

nithinpnp commented Jun 5, 2019

NelsonDaniel left a comment

nithinpnp commented Jun 7, 2019 •

edited

Loading

nithinpnp commented Jun 10, 2019

NelsonDaniel left a comment •

edited

Loading

nithinpnp commented Jun 13, 2019

shahabhijeet left a comment •

edited

Loading

majastrz Jun 17, 2019

majastrz Jun 17, 2019

majastrz Jun 17, 2019

majastrz left a comment

nithinpnp commented Jun 17, 2019

Nithin/action group webhooks with azure active directory integration #6218

Nithin/action group webhooks with azure active directory integration #6218

Conversation

nithinpnp commented Jun 4, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 4, 2019 • edited Loading

SDK Automation [Logs] (Generated from 1dca2b0)

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jun 4, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Jun 4, 2019

nithinpnp commented Jun 4, 2019

nschonni commented Jun 5, 2019

nithinpnp commented Jun 5, 2019

NelsonDaniel left a comment

Choose a reason for hiding this comment

nithinpnp commented Jun 7, 2019 • edited Loading

nithinpnp commented Jun 10, 2019

NelsonDaniel left a comment • edited Loading

Choose a reason for hiding this comment

nithinpnp commented Jun 13, 2019

shahabhijeet left a comment • edited Loading

Choose a reason for hiding this comment

majastrz Jun 17, 2019

Choose a reason for hiding this comment

majastrz Jun 17, 2019

Choose a reason for hiding this comment

majastrz Jun 17, 2019

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

nithinpnp commented Jun 17, 2019

nithinpnp commented Jun 4, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

nithinpnp commented Jun 7, 2019 •

edited

Loading

NelsonDaniel left a comment •

edited

Loading

shahabhijeet left a comment •

edited

Loading