Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency package @types/node-fetch has a new version available #19165

Closed
azure-sdk opened this issue Dec 10, 2021 · 4 comments
Closed

Dependency package @types/node-fetch has a new version available #19165

azure-sdk opened this issue Dec 10, 2021 · 4 comments
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required EngSys This issue is impacting the engineering system.

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 10, 2021

We have identified a dependency on version 2.5.0 of @types/node-fetch. A new version (2.6.4) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.

  2. Identify all packages that take a dependency on this package.

  3. Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

  4. Run rush update to ensure the new version is pulled in.

  5. Make relevant changes to absorb the breaking changes.

  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 10, 2021
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Dec 13, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 13, 2021
@ramya-rao-a ramya-rao-a added this to the [2022] February milestone Dec 15, 2021
@ramya-rao-a
Copy link
Contributor

This task should be taken up along with #19231

@joheredi
Copy link
Member

Version 3.0.3 is deprecated we should stay in the 2.x.x range. @praveenkuttappan is there any way to have the automation tool to only check for new version in the 2.x.x range for this package?

@praveenkuttappan
Copy link
Member

Automation is filing issue based on rush update output. We don't have control at package level.

@joheredi joheredi modified the milestones: [2022] February, Backlog Jan 27, 2022
@joheredi
Copy link
Member

Once #19231 is addressed we need to remove this dependency. node-fetch already has types released with the package. See details in the linked issue about why we can't migrate at this time

@joheredi joheredi removed their assignment Jan 27, 2022
@azure-sdk azure-sdk removed the Client This issue points to a problem in the data-plane of the library. label Feb 7, 2022
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Mar 9, 2022
@jeremymeng jeremymeng added the EngSys This issue is impacting the engineering system. label May 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@xirzec xirzec removed this from the Backlog milestone Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. dependency-upgrade-required EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

6 participants