[amqp-common] Browser tests are failing

[ramya0820]

On running npm run test:browser, encountering following error:

Chrome 73.0.3683 (Windows 10.0.0) ERROR
  Uncaught TypeError: undefined is not a function
  at test-browser/index.js:26153:22

  TypeError: undefined is not a function
      at test-browser/index.js:26153:22
      at test-browser/index.js:3:5
      at test-browser/index.js:4:2

Source of error is due to browser tests not getting rolled up correctly where several instances of undefined() are being generated in the final file.

Older versions of the repository are generating a different rolled up file with about 3000 less number of lines.
The goal of this issue is to investigate repository history and roll up scripts to determine fix.

[ramya0820]

@bterlson and I looked into this offline.

The rollup and tests work as expected when node_modules are generated manually using npm install.
On using rush update, the node_modules get symlinked to one in outer common ditrectory.

And all of the mappings exposed by cjs module in rollup script fail to work as expected and we see the following errors in the output:

dist-esm\test\requestResponse.spec.js
equal is not exported by ..\..\..\common\temp\node_modules\.registry.npmjs.org\assert\1.4.1\node_modules\assert\assert.js
118:                 timeoutInSeconds: 5
119:             });
120:             assert.equal(response.correlation_id, messageId);
                        ^
121:         });
122:     });
dist-esm\test\retry.spec.js
should is not exported by ..\..\..\common\temp\node_modules\.registry.npmjs.org\chai\4.2.0\node_modules\chai\index.js
 6: import debugModule from "debug";
 7: const debug = debugModule("azure:amqp-common:retry-spec");
 8: const should = chai.should();
                        ^
 9: import * as dotenv from "dotenv";
10: dotenv.config();
dist-esm\test\tokenProvider.spec.js
should is not exported by ..\..\..\common\temp\node_modules\.registry.npmjs.org\chai\4.2.0\node_modules\chai\index.js
3: import * as tslib_1 from "tslib";
4: import * as chai from "chai";
5: chai.should();

Following is the usage of these references in rollup script for reference:

     cjs({
        namedExports: {
          chai: ["should"],
          assert: ["equal", "deepEqual", "notEqual"]
        }
      })

Overall, the issue is consistently replicated when we use rush update in lieu of npm install to generate the node_modules.

@bsiegel @AlexGhiondea
@ramya-rao-a @HarshaNalluru

[bsiegel]

Can you try replacing browser: true with mainFields: ['module', 'browser'] in the nodeResolve plugin section of your browser rollup config (L124 of rollup.base.config.js)?

[ramya0820]

Can you try replacing browser: true with mainFields: ['module', 'browser'] in the nodeResolve plugin section of your browser rollup config (L124 of rollup.base.config.js)?

This fixed it, or atleast got the same outcome as npm install, thanks!

[bsiegel]

For future reference, this is due to rollup/rollup-plugin-node-resolve#94 which causes problems when you try to rollup and your node_modules contains symlinks. I will document this somewhere since it's likely to be a stumbling block.

[bsiegel]

I am adding a section to the README to cover this situation. Sorry about the confusion!