[Storage] Regenerating all the recordings at once fail because of the tests with this.skip()

[HarshaNalluru]

Record mode - NODE tests.

The tests with this.skip() doesn't execute the recorder.stop() call in the succeeding afterEach(since afterEach itself is not executed) which affects the tests that are run later on to throw an error saying NOCK recording is already in progress.

/cc - @chradek

[HarshaNalluru]

The correct behaviour should be that afterEach block should be executed when a test is skipped just like the beforeEach block, which would ensure that the ongoing recording is stopped with recorder.stop().

This is a bug in the mocha library that afterEach block is not being executed if a test is skipped unlike beforeEach.

• Related issue - Test case skip()ed, beforeEach() hook still executed, afterEach() missed mochajs/mocha#2546
• Bug - 🗣️ Discussion: this.skip() - bug summary mochajs/mocha#3740
• They claim to fix it here - Fix hook pattern of this.skip() in it() tests mochajs/mocha#3859 (which is merged to master)

This hasn't been fixed in 6.2.2 version(latest).
Version 7.0.0(hasn't been released yet) will have the fix.

Update - Tested this branch mochajs/mocha#3741, this seems to fix things :)

[HarshaNalluru]

The issue is fixed in mocha 7.0.0 - mochajs/mocha#3741

However, after updating mocha to 7.0.0 in the central repo's SDKs,
rush update failed as below.

This issue occurred because mocha-multi is still relying on an older version of mocha.

For comparison, npm throws a warning only

glenjamin/mocha-multi#68 - Logged an issue in the mocha-multi repo asking them to support mocha@7.0.0

[ramya-rao-a]

@HarshaNalluru Is there anything we need to do for Storage specifically here if we update mocha across the repo?

[HarshaNalluru]

This was seen with storage at the time. It should be independent of storage.
We logged issues, I had verified their PR upon their request for the bug fix.
And they eventually released the new version.
And long back, I had added an alternative for mocha-multi, so nothing left to do here.