Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding explicit net6.0 targetFramework outputs for all clients #28492

Closed
christothes opened this issue May 2, 2022 · 5 comments · May be fixed by #28911
Closed

Consider adding explicit net6.0 targetFramework outputs for all clients #28492

christothes opened this issue May 2, 2022 · 5 comments · May be fixed by #28911
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@christothes
Copy link
Member

Library name

Azure.Core

Please describe the feature.

From this customer issue

Consider targeting newer frameworks to reduce client dependency sets. For any packages which have been absorbed into the framework this is safe and compatible. We can also potentially benefit by using the new API and functionality available in those new frameworks.

PS: The only place to be careful about this is with packages like Microsoft.BCL.AsyncInterfaces -- those were not absorbed by the framework and need to remain exposed -- or even better if you ever use them try to avoid exposing them by using PrivateAssets="Compile"

@AraHaan
Copy link

AraHaan commented May 2, 2022

Sad we cant look into alternatives to Microsoft.BCL.AsyncInterfaces that are built into the framework.

@AraHaan
Copy link

AraHaan commented May 2, 2022

Oh interesting:
image

I guess for .NET an experiment could be done to see if the Azure SDK will compile without the reference on .NET Core/5 and 6+ TFMs. That dependency might just be adding type forwards to everything in it to things in System.Runtime.

@jsquire jsquire added the Client This issue points to a problem in the data-plane of the library. label May 3, 2022
@ViktorHofer
Copy link
Contributor

I guess for .NET an experiment could be done to see if the Azure SDK will compile without the reference on .NET Core/5 and 6+ TFMs. That dependency might just be adding type forwards to everything in it to things in System.Runtime.

Correct. Microsoft.Bcl.AsyncInterfaces is just a facade when used on any tfm that's compatible with netstandard2.1 (.NETCoreApp mainly): https://github.com/dotnet/runtime/blob/e3860440c151897968eca2227ae98c1912580c44/src/libraries/Microsoft.Bcl.AsyncInterfaces/src/Microsoft.Bcl.AsyncInterfaces.csproj#L15.

I don't have full context on what your clients currently target but the Microsoft.Bcl.AsyncInterfaces package should only be required when targeting .NETFramework or .NETStandard < 2.1.

AraHaan added a commit to AraHaan/azure-sdk-for-net that referenced this issue May 22, 2022
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>

Fixes Azure#28477.
Fixes Azure#28492.
Fixes Azure#28577.
@christothes christothes added this to the Backlog milestone May 11, 2023
@pallavit
Copy link
Contributor

@christothes given our latest conversation on target frameworks - do you still see this as a valid concern?

Copy link

github-actions bot commented May 3, 2024

Hi @christothes, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants