Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure resource names are URI-escaped #16292

Closed
wants to merge 1 commit into from

Conversation

heaths
Copy link
Member

@heaths heaths commented Oct 26, 2020

Partly fixes #15784

@ghost ghost added the KeyVault label Oct 26, 2020
@heaths heaths requested a review from schaabs October 26, 2020 23:43
@heaths
Copy link
Member Author

heaths commented Oct 26, 2020

Even if I escape the path segments including the certificate, key, or secret name,

  1. ":" is a valid path character but still gets rejected (HTML error response).
  2. ":" query string-escaped as "%3a" still gets rejected (HTML error response).

The " " (space) in a name still seems to work based on testing, as does "(" and ")". This seems to be a problem with the service, so I don't think the code changes here are necessary.

@jsquire
Copy link
Member

jsquire commented Nov 28, 2020

Hi @heaths. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream or if the PR should be closed out?

@jsquire jsquire added the no-recent-activity There has been no recent activity on this issue. label Nov 28, 2020
@heaths
Copy link
Member Author

heaths commented Dec 1, 2020

I'm following up here: #15784 (comment)

@jsquire jsquire removed the no-recent-activity There has been no recent activity on this issue. label Dec 4, 2020
@heaths
Copy link
Member Author

heaths commented Dec 7, 2020

Closing as the service cannot address the bug at this time, and - while the error message is not helpful - the behavior with getting a RequestFailedException is correct and we don't want to overzealously pin to a current behavior that may cause compatibility issues in the future.

@heaths heaths closed this Dec 7, 2020
@heaths heaths deleted the issue15784 branch June 28, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] KeyVault ImportKey() gives "Service request failed" Error 400 when importing a key with invalid name
2 participants