-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dynatrace] Onboard track2 management sdk #28821
Conversation
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - dynatrace - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check for API changes have been detected in |
...race/Azure.ResourceManager.Dynatrace/src/Generated/Models/LinkableEnvironmentListResponse.cs
Outdated
Show resolved
Hide resolved
sdk/dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/AvailabilityState.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several Id
s (like TenantId
, EnterpriseAppId
, EnvironmentId
). Make sure they follow the correct type?
sdk/dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/MonitoredResource.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @divyansh3131, could you help confirm the correct answers to all the questions about the type in the comments, are they Guid
, ResourceIdentifier(such as /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}
) or AzureLocation or something else?
...dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/LinkableEnvironmentContent.cs
Outdated
Show resolved
Hide resolved
...dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/LinkableEnvironmentContent.cs
Outdated
Show resolved
Hide resolved
...dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/LinkableEnvironmentContent.cs
Outdated
Show resolved
Hide resolved
sdk/dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/IdentityProperties.cs
Outdated
Show resolved
Hide resolved
...dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/DynatraceSingleSignOnResourceData.cs
Outdated
Show resolved
Hide resolved
...race/Azure.ResourceManager.Dynatrace/src/Generated/Models/DynatraceSingleSignOnProperties.cs
Outdated
Show resolved
Hide resolved
sdk/dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/EnvironmentInfo.cs
Outdated
Show resolved
Hide resolved
...ynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/LinkableEnvironmentResponse.cs
Outdated
Show resolved
Hide resolved
sdk/dynatrace/Azure.ResourceManager.Dynatrace/src/Generated/Models/VmExtensionPayload.cs
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. Azure.ResourceManager.Dynatrace |
* Initialize track2 mgmt sdk of dynatrace * correct cspell * resolve comments * still comment * update api * correct the type * empty folder * regen * update changelog
* Initialize track2 mgmt sdk of dynatrace * correct cspell * resolve comments * still comment * update api * correct the type * empty folder * regen * update changelog
* Initialize track2 mgmt sdk of dynatrace * correct cspell * resolve comments * still comment * update api * correct the type * empty folder * regen * update changelog
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.