Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynatrace] Onboard track2 management sdk #28821

Merged
merged 9 commits into from
May 19, 2022

Conversation

Yao725
Copy link
Member

@Yao725 Yao725 commented May 17, 2022

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@Yao725
Copy link
Member Author

Yao725 commented May 17, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Yao725
Copy link
Member Author

Yao725 commented May 17, 2022

/azp run net - dynatrace - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 17, 2022

API change check for Azure.ResourceManager.Dynatrace

API changes have been detected in Azure.ResourceManager.Dynatrace. You can review API changes here

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several Ids (like TenantId, EnterpriseAppId, EnvironmentId). Make sure they follow the correct type?

Copy link
Member Author

@Yao725 Yao725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @divyansh3131, could you help confirm the correct answers to all the questions about the type in the comments, are they Guid, ResourceIdentifier(such as /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}) or AzureLocation or something else?

@Yao725 Yao725 linked an issue May 19, 2022 that may be closed by this pull request
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Dynatrace
Azure.ResourceManager.DynaTrace

@Yao725 Yao725 merged commit 7b35190 into Azure:main May 19, 2022
@Yao725 Yao725 deleted the track2-mgmt-dynatrace branch May 19, 2022 08:47
sarkar-rajarshi pushed a commit to sarkar-rajarshi/azure-sdk-for-net that referenced this pull request Jun 10, 2022
* Initialize track2 mgmt sdk of dynatrace

* correct cspell

* resolve comments

* still comment

* update api

* correct the type

* empty folder

* regen

* update changelog
paterasMSFT pushed a commit that referenced this pull request Jun 15, 2022
* Initialize track2 mgmt sdk of dynatrace

* correct cspell

* resolve comments

* still comment

* update api

* correct the type

* empty folder

* regen

* update changelog
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
* Initialize track2 mgmt sdk of dynatrace

* correct cspell

* resolve comments

* still comment

* update api

* correct the type

* empty folder

* regen

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial Azure.ResourceManager.DynaTrack
4 participants