Fix offline storage during network errors #38832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
vishweshbankwar
requested review from
cijothomas,
reyang,
rajkumar-rangaraj and
TimothyMothra
as code owners
TimothyMothra
approved these changes
Sep 19, 2023
|
nit: consider a changelog entry to describe that we fixed this bug. |
...tor/Azure.Monitor.OpenTelemetry.Exporter/src/Customizations/ApplicationInsightsRestClient.cs
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Sep 19, 2023
m-nash
added a commit
that referenced
this pull request
Sep 21, 2023
* Add TraceSpan * Add TraceSpan * version funkiness for diagnostics * Update readme and troubleshooting guide (#38825) * test utilities (#38828) * test utilities * fix usings * [Storage] Storage Client Options Support Audiences (#38438) * Initial work for Blob Clients to support Audience * Export API * Moved BlobAudience to Models; Added Audience support in DataLake; Addressed PR commeents * Added audience support for Shares and Queues; Recorded tests; Cannot record tests for files audience tests * Rerecord failure expected tests * Adding default scope after resource id is set; Recorded Share Files tests * Actually removing /.default from tests and correct order of what default to use * Trying to resolve CI issues with Audience.Equals(string) * Attempt to fix CI issues * Cleanup * Timeout for httpclient for VM metadata service and suppress statsbeat instrumentation (#38801) * timeout for httpclient and suppress instrument * Update AzureMonitorExporterEventSource.cs update EventSource message --------- Co-authored-by: Timothy Mothra <tilee@microsoft.com> * Fix offline storage during network errors (#38832) * Fix offline storage during network errors * fix net462 * changelog * remove TraceSpan types * Fix multiple triggers of the same type adding to DI (#38756) * Fix multiple triggers of the same type adding to DI * Compare with created instance * Enabling ScaleHostEndToEndTest again * Adding a comment * export API * Refactor TryGetHeader on Response * undo KeyVault * backout Personalizer * undo storage * undo web pub sub * Fix naming in AddAzureStorageQueuesScaleForTrigger (#38843) * Add tracing types * renames * Support MaxConcurrentCallsPerSession (#38836) * Storage STG 91 (#38839) * Fix the ValidateInheritance naming test failures (#38844) * update * [RecoveryServicesBackup] Fix LRO issue (#38784) * Add LRO * Update CHANGELOG.md * Update comments * Add regression tests * Update assets.json * update --------- Co-authored-by: Chengming <v-cruan@microsoft.com> Co-authored-by: Wei Hu <huwe@microsoft.com> * Fix the IPAddress serialization issue for Peering (#38824) * Remove Credential * API * refactor * remove net461 target * Update AutoRest C# version to 3.0.0-beta.20230920.1 (#38852) * Update Generator Version 3.0.0-beta.20230920.1 * Update SDK codes * Update SDK codes * Update SDK codes * undo kv * updates * missed fies * Richardcho/cancel add participant (#38794) * update swagger * update swagger * apply swagger updates * update api * Revert "apply swagger updates" This reverts commit 99ebc37. * auto generate * add method * add internal events * update api * update api * update swagger * auto generate * add events * add event processor changes * fix build * update api * update code * update typo * fix typo * add unit tests * remove dupe file * update swagger * fix typo * fix typo * fix test * address PR comments --------- Co-authored-by: root <root@DESKTOP-6GBNLER> * [AzureMonitorDistro] disable test (#38840) * fix test * investigating test... * investigating tests * disable test * IUtf8JsonSerializable * Argument * [AzureMonitorDistro] update OTel ResourceDetectors (#38833) * update ResourceDetectors * changelog * [AzureMonitorExporter] prepare new release. Exporter 1.0.0. Distro beta7 (#38838) * bump version * update Readme * fix date * fix changelog header * prepare Distro * [Storage][DataMovement] Add resource specific checkpoint data classes (#38842) * RawRequestUriBuilder * HttpExtensions - 1 * temp * WIP: HttpPipelineExtensions * WIP: HttpPipelineExtensions * Increment version for monitor releases (#38864) * Increment package version after release of Azure.Monitor.OpenTelemetry.Exporter * Increment package version after release of Azure.Monitor.OpenTelemetry.AspNetCore * PipelineProtocolExtensions * export API * Increment package version after release of Azure.Identity (#38667) * add CreateMessage to pipeline * Add constructor to HttpMessage * API * .NET SDK release changes for dataprotection (#38408) * generating sdk for 2023-05-01 Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Addressing breaking change comment Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Changes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Handling breaking changes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * generating sdk for 2023-05-01 Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Addressing breaking change comment Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Changes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Handling breaking changes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Updated DataProtectionBackupVaultProperties * resolved breaking changes in ArmDataProtectionBackupModelFactory * Add changelog Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * fixes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Renaming parameters Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Update changelog Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Added expected release date Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Renamed NamespacedNameResource Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> --------- Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com> Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com> * fix chainingclassifier * Optional * API * Utf8JsonRequestBody * Update MSAL dependencies to latest (#38866) * STJ type extensions * move generated oai client into this branch * pipeline builder for custom policies * implement Pipeline.Send * make shared source RawRequestUriBuilder still work without new project ref * starting to think about policy * fix --------- Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> Co-authored-by: Anne Thompson <annelo@microsoft.com> Co-authored-by: Christopher Scott <chriss@microsoft.com> Co-authored-by: Jocelyn <41338290+jaschrep-msft@users.noreply.github.com> Co-authored-by: Amanda Nguyen <48961492+amnguye@users.noreply.github.com> Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> Co-authored-by: Alexey Rodionov <alrod@inbox.ru> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com> Co-authored-by: Arthur Ma <arthurma@microsoft.com> Co-authored-by: Minghao Chen <30464227+HarveyLink@users.noreply.github.com> Co-authored-by: Chengming <v-cruan@microsoft.com> Co-authored-by: Wei Hu <huwe@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: richardcho-msft <95773682+richardcho-msft@users.noreply.github.com> Co-authored-by: root <root@DESKTOP-6GBNLER> Co-authored-by: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com> Co-authored-by: Shashank Singh <shashank1306s@gmail.com> Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com> Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com>
yaotongms
pushed a commit
to yaotongms/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2023
* Fix offline storage during network errors * fix net462 * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing
ResponseonhttpMessagewhen there is no Response throws an exception. We first need to check for response. This was causing an issue during network failures. (Telemetry was not stored offline due to this exception).