Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MaxConcurrentCallsPerSession #38836

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Support MaxConcurrentCallsPerSession #38836

merged 1 commit into from
Sep 20, 2023

Conversation

JoshLove-msft
Copy link
Member

Addresses #38157

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Azure.WebJobs.Extensions.ServiceBus

@JoshLove-msft
Copy link
Member Author

/cc @mathewc for dynamic concurrency considerations

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft JoshLove-msft enabled auto-merge (squash) September 19, 2023 22:15
@JoshLove-msft JoshLove-msft merged commit 701b695 into Azure:main Sep 20, 2023
35 checks passed
@gorillapower
Copy link

@JoshLove-msft just to confirm the MaxConcurrentCallsPerSession will not scale dynamically when DynamicConcurrency is enabled? Is that correct? I see that there may be some conflicting comments in the code.

  1. States dynamic concurrency is supported - https://github.com/Azure/azure-sdk-for-net/pull/38836/files#diff-4a6c862ba7e4713fc37da3fe62c9eab4702ed7cbb3cb1bd93b46e845e04462dcR139
  2. Stats dynamic concurrency is not supporte - https://github.com/Azure/azure-sdk-for-net/pull/38836/files#diff-4a6c862ba7e4713fc37da3fe62c9eab4702ed7cbb3cb1bd93b46e845e04462dcR335

@JoshLove-msft
Copy link
Member Author

@JoshLove-msft just to confirm the MaxConcurrentCallsPerSession will not scale dynamically when DynamicConcurrency is enabled? Is that correct? I see that there may be some conflicting comments in the code.

  1. States dynamic concurrency is supported - https://github.com/Azure/azure-sdk-for-net/pull/38836/files#diff-4a6c862ba7e4713fc37da3fe62c9eab4702ed7cbb3cb1bd93b46e845e04462dcR139
  2. Stats dynamic concurrency is not supporte - https://github.com/Azure/azure-sdk-for-net/pull/38836/files#diff-4a6c862ba7e4713fc37da3fe62c9eab4702ed7cbb3cb1bd93b46e845e04462dcR335

Correct, the current implementation of dynamic concurrency does not scale the new setting. I can clarify this in the doc comments.

m-nash added a commit that referenced this pull request Sep 21, 2023
@m-nash @annelo-msft
@christothes @jaschrep-msft @amnguye @vishweshbankwar @TimothyMothra @alrod @JoshLove-msft @seanmcc-msft @ArthurMa1978 @HarveyLink @dvbb @live1206 @azure-sdk @richardcho-msft @jalauzon-msft @Shashank1306s @hiaga
Core experiment2 client (#38893)
39fc6ef 
* Add TraceSpan

* Add TraceSpan

* version funkiness for diagnostics

* Update readme and troubleshooting guide (#38825)

* test utilities (#38828)

* test utilities

* fix usings

* [Storage] Storage Client Options Support Audiences (#38438)

* Initial work for Blob Clients to support Audience

* Export API

* Moved BlobAudience to Models; Added Audience support in DataLake; Addressed PR commeents

* Added audience support for Shares and Queues; Recorded tests; Cannot record tests for files audience tests

* Rerecord failure expected tests

* Adding default scope after resource id is set; Recorded Share Files tests

* Actually removing /.default from tests and correct order of what default to use

* Trying to resolve CI issues with Audience.Equals(string)

* Attempt to fix CI issues

* Cleanup

* Timeout for httpclient for VM metadata service and suppress statsbeat instrumentation (#38801)

* timeout for httpclient and suppress instrument

* Update AzureMonitorExporterEventSource.cs

update EventSource message

---------

Co-authored-by: Timothy Mothra <tilee@microsoft.com>

* Fix offline storage during network errors (#38832)

* Fix offline storage during network errors

* fix net462

* changelog

* remove TraceSpan types

* Fix multiple triggers of the same type adding to DI (#38756)

* Fix multiple triggers of the same type adding to DI

* Compare with created instance

* Enabling ScaleHostEndToEndTest again

* Adding a comment

* export API

* Refactor TryGetHeader on Response

* undo KeyVault

* backout Personalizer

* undo storage

* undo web pub sub

* Fix naming in AddAzureStorageQueuesScaleForTrigger (#38843)

* Add tracing types

* renames

* Support MaxConcurrentCallsPerSession (#38836)

* Storage STG 91 (#38839)

* Fix the ValidateInheritance naming test failures (#38844)

* update

* [RecoveryServicesBackup] Fix LRO issue (#38784)

* Add LRO

* Update CHANGELOG.md

* Update comments

* Add regression tests

* Update assets.json

* update

---------

Co-authored-by: Chengming <v-cruan@microsoft.com>
Co-authored-by: Wei Hu <huwe@microsoft.com>

* Fix the IPAddress serialization issue for Peering (#38824)

* Remove Credential

* API

* refactor

* remove net461 target

* Update AutoRest C# version to 3.0.0-beta.20230920.1 (#38852)

* Update Generator Version 3.0.0-beta.20230920.1

* Update SDK codes

* Update SDK codes

* Update SDK codes

* undo kv

* updates

* missed fies

* Richardcho/cancel add participant (#38794)

* update swagger

* update swagger

* apply swagger updates

* update api

* Revert "apply swagger updates"

This reverts commit 99ebc37.

* auto generate

* add method

* add internal events

* update api

* update api

* update swagger

* auto generate

* add events

* add event processor changes

* fix build

* update api

* update code

* update typo

* fix typo

* add unit tests

* remove dupe file

* update swagger

* fix typo

* fix typo

* fix test

* address PR comments

---------

Co-authored-by: root <root@DESKTOP-6GBNLER>

* [AzureMonitorDistro] disable test (#38840)

* fix test

* investigating test...

* investigating tests

* disable test

* IUtf8JsonSerializable

* Argument

* [AzureMonitorDistro] update OTel ResourceDetectors (#38833)

* update ResourceDetectors

* changelog

* [AzureMonitorExporter] prepare new release. Exporter 1.0.0. Distro beta7 (#38838)

* bump version

* update Readme

* fix date

* fix changelog header

* prepare Distro

* [Storage][DataMovement] Add resource specific checkpoint data classes (#38842)

* RawRequestUriBuilder

* HttpExtensions - 1

* temp

* WIP: HttpPipelineExtensions

* WIP: HttpPipelineExtensions

* Increment version for monitor releases (#38864)

* Increment package version after release of Azure.Monitor.OpenTelemetry.Exporter

* Increment package version after release of Azure.Monitor.OpenTelemetry.AspNetCore

* PipelineProtocolExtensions

* export API

* Increment package version after release of Azure.Identity (#38667)

* add CreateMessage to pipeline

* Add constructor to HttpMessage

* API

* .NET SDK release changes for dataprotection (#38408)

* generating sdk for 2023-05-01

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Addressing breaking change comment

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Changes

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Handling breaking changes

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* generating sdk for 2023-05-01

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Addressing breaking change comment

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Changes

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Handling breaking changes

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Updated DataProtectionBackupVaultProperties

* resolved breaking changes in ArmDataProtectionBackupModelFactory

* Add changelog

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* fixes

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Renaming parameters

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Update changelog

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Added expected release date

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

* Renamed NamespacedNameResource

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>

---------

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>
Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com>
Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com>

* fix chainingclassifier

* Optional

* API

* Utf8JsonRequestBody

* Update MSAL dependencies to latest (#38866)

* STJ type extensions

* move generated oai client into this branch

* pipeline builder for custom policies

* implement Pipeline.Send

* make shared source RawRequestUriBuilder still work without new project ref

* starting to think about policy

* fix

---------

Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com>
Co-authored-by: Anne Thompson <annelo@microsoft.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
Co-authored-by: Jocelyn <41338290+jaschrep-msft@users.noreply.github.com>
Co-authored-by: Amanda Nguyen <48961492+amnguye@users.noreply.github.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Timothy Mothra <tilee@microsoft.com>
Co-authored-by: Alexey Rodionov <alrod@inbox.ru>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com>
Co-authored-by: Arthur Ma <arthurma@microsoft.com>
Co-authored-by: Minghao Chen <30464227+HarveyLink@users.noreply.github.com>
Co-authored-by: Chengming <v-cruan@microsoft.com>
Co-authored-by: Wei Hu <huwe@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: richardcho-msft <95773682+richardcho-msft@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-6GBNLER>
Co-authored-by: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com>
Co-authored-by: Shashank Singh <shashank1306s@gmail.com>
Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com>
Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com>
yaotongms pushed a commit to yaotongms/azure-sdk-for-net that referenced this pull request Oct 12, 2023
@JoshLove-msft @yaotongms
Support MaxConcurrentCallsPerSession (Azure#38836)
4c642a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

Assignees
No one assigned
Labels
Functions Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoshLove-msft @azure-sdk @gorillapower @jsquire