-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Edition and Customized script support for SSIS IR #4001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do the following in the below order:
- Pull latest from upstream (if you have already done this good)
- Execute msbuild.exe build.proj from the repo root
a. This will update the build tools in the current repo - Generate your SDK using generate.cmd
a. this creates meta data files that are needed. - Build you sdk at least once from command line of IDE
a. (From command line use this) Msbuild.exe build.proj /t:build /p:Scope=SDKs\DataFactory
b. this will create another additional meta data file that is also needed. - Update the PR
1f46234
to
b92c766
Compare
6fa2964
to
e3ce1a2
Compare
Have follow the steps, and for step 3, I use this command to generate code |
@chinadragon0515 can you resolve the conflict. |
e3ce1a2
to
4993b5f
Compare
Just update the code with regenerated code based on newest specification, can someone help to review and merge the PR, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing 1 meta data file.
Build your project from command line to get the new meta data file
msbuild build.proj /t:build /p:Scope=SDKs\DataFactory
I have run msbuild build.proj /t:build /p:Scope=SDKs\DataFactory, and there is meta file changed, I just commit the meta file change into single commit, the file changed is src/SDKs/_metadata/datafactory_resource-manager.txt Anything else I missed and need to be done? thanks |
@chinadragon0515 I just cloned your fork and regenerated the SDK.
|
4993b5f
to
f720d4d
Compare
Detail steps I have done,
|
Description
This change is add edition and customized script support for SSIS IR, there is no manually code change, all the code change are generated with spec change in this PR
Azure/azure-rest-api-specs#2266
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.