[Azure Search] Fixing some long-lived bugs in the data plane SDK #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version bump is in preparation for a series of bug fixes that have been pending for a long time. The build script change was taken from the old abandoned vs17Dev branch.
The FieldBuilder class in the Search .NET SDK now ignores properties marked with JsonIgnore.
…andler Fixes an issue whereby setting the HttpClientHandler when creating a SearchServiceClient has no effect on the SearchIndexClient returned by Indexes.GetClient. This would break scenarios such as enabling GZip compression, for example. Now the HttpClientHandler propagates, but the DelegatingHandlers don't since they can't be cloned and are mutated by the ServiceClient base class constructor.
|
@azuresdkci retest this please |
Yahnoosh
reviewed
Feb 3, 2018
| { | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
should we add a regression test for this? #Closed
There was a problem hiding this comment.
@Yahnoosh There are already test changes for this. Look at the test model class. #Closed
There was a problem hiding this comment.
|
@azuresdkci retest this please |
shahabhijeet
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few long-standing bugs in the Azure Search data plane SDK. You won't see it in the commits, but one of the bugs fixed is the incompatibility with JSON.NET 10.0.1. This is fixed just by virtue of rebuilding the SDK with the latest
ClientRuntimeon the correct branch (psSdk6Jsoninstead ofvs17Dev).The other fixes are for these issues:
There are no Swagger changes and no breaking changes in this PR. This PR bumps the SDK version number from 3.0.4 to 3.0.5.
See individual commits for more details.
FYI @Yahnoosh @mhko @updixit @shahabhijeet
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.