-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Search] Fixing some long-lived bugs in the data plane SDK #4036
Conversation
The version bump is in preparation for a series of bug fixes that have been pending for a long time. The build script change was taken from the old abandoned vs17Dev branch.
The FieldBuilder class in the Search .NET SDK now ignores properties marked with JsonIgnore.
…andler Fixes an issue whereby setting the HttpClientHandler when creating a SearchServiceClient has no effect on the SearchIndexClient returned by Indexes.GetClient. This would break scenarios such as enabling GZip compression, for example. Now the HttpClientHandler propagates, but the DelegatingHandlers don't since they can't be cloned and are mutated by the ServiceClient base class constructor.
@azuresdkci retest this please |
{ | ||
continue; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a regression test for this? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yahnoosh There are already test changes for this. Look at the test model class. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azuresdkci retest this please |
Description
This PR fixes a few long-standing bugs in the Azure Search data plane SDK. You won't see it in the commits, but one of the bugs fixed is the incompatibility with JSON.NET 10.0.1. This is fixed just by virtue of rebuilding the SDK with the latest
ClientRuntime
on the correct branch (psSdk6Json
instead ofvs17Dev
).The other fixes are for these issues:
There are no Swagger changes and no breaking changes in this PR. This PR bumps the SDK version number from 3.0.4 to 3.0.5.
See individual commits for more details.
FYI @Yahnoosh @mhko @updixit @shahabhijeet
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.