#41629 Add net 6 and use conditional packages in Azure.Identity #41630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompson-tomo
requested review from
schaabs,
christothes and
a team
as code owners
thompson-tomo
requested review from
maorleger,
joshfree,
billwert,
ahsonkhan and
mpodwysocki
github-actions
bot
added
Azure.Identity
Community Contribution
|
Thank you for your contribution @thompson-tomo! We will review the pull request and get back to you soon. |
thompson-tomo
changed the title
|
@microsoft-github-policy-service agree |
|
Hi @thompson-tomo. Thank you for your contribution and interest in improving the Azure developer experience. Unfortunately, this is not a change that we're ready to accept, pending discussion in #41628. If we decide to move forward with conditional references, we will most likely do so centrally so that it can be maintained in a single place and apply to all Azure SDK packages with the known-safe targets. I'm going to close this out. Thank you, again, for your contribution. |
thompson-tomo
deleted the
chore/#41629_AzureIdentityConditionalPackages
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds net 6 as a TFM for Azure.Identity so that conditional packages can be added. By having net 6 as a TFM the below packages are not needed for net 6 due to being part of the framework.
Closes