Only determine success of request based on statuscode when the Activity Status is Unset

[rvanheest]

Fixes #41993

When a non-2xx response from a web request should not be marked as an error in OpenTelemetry, you can set the Activity's status to ActivityStatusCode.Ok manually.

builder
    .AddAspNetCoreInstrumentation(options =>
    {
        options.EnrichWithHttpResponse = (activity, response) =>
        {
            if (response.StatusCode == 404)
            {
                activity.SetStatus(ActivityStatusCode.Ok);
            }
        };
    })
    .AddConsoleExporter()
    .AddAzureMonitorTraceExporter(options =>
    {
        options.ConnectionString = "<my connection string>";
    });

However, even though the status was set to Ok, the ApplicationInsights exporter still treats it like an error because of the response code being >= 400. This should only happen in cases where activity.Status == ActivityStatusCode.Unset.

Added to the RequestData.IsSuccess function is this extra check. Also, inside the if now the expression activity.Status != ActivityStatusCode.Error becomes always true and can hence be removed.

[github-actions]

Thank you for your contribution @rvanheest! We will review the pull request and get back to you soon.

[rvanheest]

@microsoft-github-policy-service agree

[TimothyMothra]

LGTM. Need to update changelog.

[rvanheest]

LGTM. Need to update changelog.

@TimothyMothra updated changelog

[vishweshbankwar]

Thanks @rvanheest!