Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] adding filter property for Autocomplete in SDK #5822

Merged
merged 4 commits into from
Apr 23, 2019

Conversation

ishansrivastava90
Copy link

  • includes generated code from swagger spec from azure-rest-api-specs:master
  • added custom code to AutocompleteParameters for POST flavor of the API
  • added tests for the property

@ishansrivastava90
Copy link
Author

@brjohnstmsft FYI.

@brjohnstmsft
Copy link
Member

@ishansrivastava90 The build failure appears to be a bug in another Azure service's SDK. I'll merge from master again to resolve it. Sorry for the inconvenience.

@brjohnstmsft
Copy link
Member

Will merge once builds are passing

@brjohnstmsft brjohnstmsft self-assigned this Apr 18, 2019
@ishansrivastava90
Copy link
Author

ishansrivastava90 commented Apr 18, 2019

@brjohnstmsft @dsgouda The CI/Travis-CI check is failing consistently with the message,

"E: Failed to fetch https://packages.microsoft.com/ubuntu/14.04/prod/dists/trusty/main/binary-amd64/Packages.gz Hash Sum mismatch
E: Some index files failed to download. They have been ignored, or old ones used instead.
The command "sudo apt-get update" failed and exited with 100 during."

Any ideas as to get this to pass?

@dsgouda
Copy link
Contributor

dsgouda commented Apr 19, 2019

@ishansrivastava90 We're taking a look

@ishansrivastava90
Copy link
Author

@dsgouda Both @brjohnstmsft and I are going to be OOF for the 1st part of the next week. If the issue is determined and fixed before we are back, feel free to merge the PR.

@dsgouda
Copy link
Contributor

dsgouda commented Apr 22, 2019

@ishansrivastava90 Please pull lkatest changes from master and update this PR, that should fix the CI issues

@dsgouda dsgouda merged commit ca7cff1 into Azure:search-preview Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants