Expose client closed flag publicly #7365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
approved these changes
Aug 22, 2019
sdk/eventhub/Microsoft.Azure.EventHubs/tests/Client/MiscTests.cs
Outdated
Show resolved
Hide resolved
…nto serkar.AddIsClosedOnClients
serkantkaraca
added
Event Hubs
Client
pakrym
reviewed
Aug 22, 2019
| @@ -20,6 +20,9 @@ public abstract class ClientEntity | |||
| static int nextId; | |||
| RetryPolicy retryPolicy; | |||
|
|
|||
| /// <summary /> | |||
| protected bool closeCalled = false; | |||
There was a problem hiding this comment.
Why is this field protected and named this way?
There was a problem hiding this comment.
Sorry, missed to notice your comment. I see your point. I will remove it and set the property setter as protected instead in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding bool IsClosed on EventHubClient, PartitionSender, and PartitionReceiver.