-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose client closed flag publicly #7365
Merged
serkantkaraca
merged 12 commits into
Azure:master
from
serkantkaraca:serkar.AddIsClosedOnClients
Aug 22, 2019
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c282f9a
Remove common authority and bump up the packaging/assembly versions.
serkantkaraca 03ddf67
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
serkantkaraca 3e2d38d
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
serkantkaraca 546d3a6
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
serkantkaraca a77cfd8
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
serkantkaraca 4e5cc09
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
serkantkaraca aa371cc
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
serkantkaraca a6573dd
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
serkantkaraca b14c6c5
Expose client closed flag publicly
serkantkaraca 1ea71a1
Fix test to crete PartitionReceiver
serkantkaraca 2b59b1e
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net i…
serkantkaraca 8989424
Adding more tests for client close.
serkantkaraca File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this field protected and named this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed to notice your comment. I see your point. I will remove it and set the property setter as protected instead in another PR.