Skip to content

Commit

Permalink
Share APIView Pins of pylint-guidelines-checker (#24258)
Browse files Browse the repository at this point in the history
* linting does NOT require the apistubgenpackage. given that it has a conflict with our pinned pylint (2.9.3) we will simply not introduce it to the linting dependency graph. instead we will simply pin 
* pin apistubgen requirements in a separate file
  • Loading branch information
scbedd authored May 17, 2022
1 parent 79ffc05 commit 33efbeb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions eng/apiview_reqs.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
api-stub-generator==0.3.1
pylint-guidelines-checker==0.0.3
4 changes: 2 additions & 2 deletions eng/tox/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ setenv =
deps =
{[base]deps}
commands =
{envbindir}/python -m pip install --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/" pylint-guidelines-checker==0.0.2
{envbindir}/python -m pip install pylint-guidelines-checker==0.0.3 --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
{envbindir}/python {toxinidir}/../../../eng/tox/create_package_and_install.py \
-d {distdir} \
-p {toxinidir} \
Expand Down Expand Up @@ -330,7 +330,7 @@ deps =
{[base]deps}
commands =
# install API stub generator
{envbindir}/python -m pip install api-stub-generator==0.3.1 --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
{envbindir}/python -m pip install -r {toxinidir}/../../../eng/apiview_reqs.txt --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
{envbindir}/python -m pip freeze
{envbindir}/python {toxinidir}/../../../eng/tox/run_apistubgen.py -t {toxinidir} -w {envtmpdir} {posargs}

Expand Down

0 comments on commit 33efbeb

Please sign in to comment.