Fix AzureCliCredential tests on Windows Python < 3.8 #10177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
Client
|
Can one of the admins verify this patch? |
xiangyan99
approved these changes
Mar 9, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 10, 2020
…into web_regeneration * 'master' of https://github.com/Azure/azure-sdk-for-python: (36 commits) [Storage][ADLS] API updates (Azure#10170) [ADLS]Update AccessPolicy and ChangeLog (Azure#10208) Search docs updates (Azure#10207) Azure-mgmt-core (Azure#5399) [Storage][Blob]Regenerate Swagger Code (Azure#10203) [Event Hubs] Fix typing.Deque problem for Python 3.5.3 (Azure#10206) Simplify AzureCliCredential working directory (Azure#10185) [ADLS]API Review Comments (Azure#10194) Ignore ARM pipeline clients too (Azure#10204) Fix async AzureCliCredential tests on Windows (Azure#10177) update search user agent (Azure#10201) [Event Hubs] Correct a doc link (Azure#10196) Add facet results to search page iterator (Azure#10182) [ADLS][Samples]Add Samples for sync and async (Azure#10123) overload tracing decorator to preserve type info (Azure#9994) Fix to handle regression test when package is missing on PyPI (Azure#10180) [Synapse DataPlane]Update sample (Azure#9948) [Event Hubs] Update README link (Azure#10184) [textanalytics] Refactor exceptions to use azure-core ODataV4Format (Azure#9934) README links update in open telemetry (Azure#10176) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the event loop used by pytest-asyncio on Windows is ProactorEventLoop, which supports subprocesses (and is not the default loop for Python < 3.8). It also fixes a bug in the test of the async AzureCliCredential's fallback to the sync implementation when the configured event loop doesn't support subprocessing.