overload tracing decorator to preserve type info #9994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
lmazuel
approved these changes
Mar 9, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 10, 2020
…into web_regeneration * 'master' of https://github.com/Azure/azure-sdk-for-python: (36 commits) [Storage][ADLS] API updates (Azure#10170) [ADLS]Update AccessPolicy and ChangeLog (Azure#10208) Search docs updates (Azure#10207) Azure-mgmt-core (Azure#5399) [Storage][Blob]Regenerate Swagger Code (Azure#10203) [Event Hubs] Fix typing.Deque problem for Python 3.5.3 (Azure#10206) Simplify AzureCliCredential working directory (Azure#10185) [ADLS]API Review Comments (Azure#10194) Ignore ARM pipeline clients too (Azure#10204) Fix async AzureCliCredential tests on Windows (Azure#10177) update search user agent (Azure#10201) [Event Hubs] Correct a doc link (Azure#10196) Add facet results to search page iterator (Azure#10182) [ADLS][Samples]Add Samples for sync and async (Azure#10123) overload tracing decorator to preserve type info (Azure#9994) Fix to handle regression test when package is missing on PyPI (Azure#10180) [Synapse DataPlane]Update sample (Azure#9948) [Event Hubs] Update README link (Azure#10184) [textanalytics] Refactor exceptions to use azure-core ODataV4Format (Azure#9934) README links update in open telemetry (Azure#10176) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue I was seeing in #9989 and passes all unit tests locally, but deserves some extra scrutiny given how ubiquitous it is in the codebase.
Some notes:
The double under in
__funcappears to be necessary to help inform mypy that that parameter is intended as positional only, to allow the overloads to be resolvable (ref: https://www.python.org/dev/peps/pep-0484/#positional-only-arguments)Similarly absent being able to specify real kwarg-only params,
name_of_spanof span had to be moved to kwargs for the overloads to be resolvableThere don't appear to be any tests for the async decorator