-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support storage network access and worm removal in remove test resources script #8558
Conversation
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
16a7a95
to
2e188d6
Compare
The following pipelines have been queued for testing: |
2e188d6
to
efa223b
Compare
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8558 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
We need to be running worm removal on storage accounts in the pipeline to avoid resource build-ups for our async cleanup script. Additionally, sometimes the network access rules we apply fail on the backend due to RP throttling. In those cases we can't disable WORM because the network policy is set to Deny, meaning blob's can't be deleted (pre-req for WORM disablement). This change includes updating the network policy within the remove script to prevent these issues as a failsafe.