Skip to content

Commit

Permalink
Enable Warnings as errors
Browse files Browse the repository at this point in the history
  • Loading branch information
mathewc committed Oct 8, 2018
1 parent ec5096f commit 0f192b1
Show file tree
Hide file tree
Showing 22 changed files with 214 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,18 @@
<Description>Microsoft Azure WebJobs SDK EventHubs Extension</Description>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Azure.EventHubs.Processor" Version="2.1.0" />
<PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@
<AssemblyName>Microsoft.Azure.WebJobs.ServiceBus</AssemblyName>
<PackageId>Microsoft.Azure.WebJobs.Extensions.ServiceBus</PackageId>
<RootNamespace>Microsoft.Azure.WebJobs.ServiceBus</RootNamespace>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="..\Microsoft.Azure.WebJobs.Shared\WebJobs.Shared.projitems" Label="Shared" />

<Import Project="..\Microsoft.Azure.WebJobs.Shared.Storage\Microsoft.Azure.WebJobs.Shared.Storage.projitems" Label="Shared" />
<Import Project="..\..\build\common.props" />

Expand All @@ -11,6 +9,18 @@
<RootNamespace>Microsoft.Azure.WebJobs.Extensions.Storage</RootNamespace>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<Compile Include="..\Microsoft.Azure.WebJobs.Host.Storage\DefaultStorageCredentialsValidator.cs" Link="Shared\DefaultStorageCredentialsValidator.cs" />
<Compile Include="..\Microsoft.Azure.WebJobs.Host.Storage\Utility.cs" Link="Utility.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,18 @@
<AssemblyName>Microsoft.Azure.WebJobs.Host.Storage</AssemblyName>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<Compile Include="..\Microsoft.Azure.WebJobs.Protocols\HeartbeatCommand.cs" Link="Logging\HeartbeatCommand.cs" />
<Compile Include="..\Microsoft.Azure.WebJobs.Protocols\PersistentQueueReader.cs" Link="Logging\PersistentQueueReader.cs" />
Expand Down
12 changes: 12 additions & 0 deletions src/Microsoft.Azure.WebJobs.Host/WebJobs.Host.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@
<AssemblyName>Microsoft.Azure.WebJobs.Host</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.Host</RootNamespace>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>true</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>true</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@
<AssemblyName>Microsoft.Azure.WebJobs.Logging.ApplicationInsights</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.Logging.ApplicationInsights</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
Expand Down
10 changes: 10 additions & 0 deletions src/Microsoft.Azure.WebJobs.Logging/WebJobs.Logging.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<AssemblyName>Microsoft.Azure.WebJobs.Logging</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.Logging</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
Expand Down
4 changes: 0 additions & 4 deletions src/Microsoft.Azure.WebJobs/IAsyncCollector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@

namespace Microsoft.Azure.WebJobs
{
/// <summary>
/// Defines an asynchronous collector (an insert-only collection).
/// </summary>
/// <typeparam name="T">The type of items to collect.</typeparam>
public interface IAsyncCollector<in T>
{
/// <summary>
Expand Down
14 changes: 13 additions & 1 deletion src/Microsoft.Azure.WebJobs/WebJobs.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
<AssemblyName>Microsoft.Azure.WebJobs</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta004">
Expand All @@ -19,5 +29,7 @@
<ItemGroup>
<Folder Include="Properties\" />
</ItemGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@
<TargetFramework>netcoreapp2.1</TargetFramework>
<RootNamespace>Microsoft.Azure.WebJobs.EventHubs.UnitTests</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
<AssemblyName>Microsoft.Azure.WebJobs.ServiceBus.UnitTests</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.ServiceBus.UnitTests</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<ItemGroup>
<Compile Remove="EventHubTests.cs" />
<Compile Remove="Listeners\EventHubListenerTests.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
<AssemblyName>Microsoft.Azure.WebJobs.Host.EndToEndTests</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.Host.EndToEndTests</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ public class DispatchQueueTests
private const string HostId = "functionalTestHost";

// provide default mock
private readonly Mock<IHostIdProvider> _hostIdMock;
private readonly Mock<IWebJobsExceptionHandler> _exceptionMock;
//private readonly Mock<IHostIdProvider> _hostIdMock;
//private readonly Mock<IWebJobsExceptionHandler> _exceptionMock;
//private Mock<IContextSetter<IMessageEnqueuedWatcher>> _messageEnqueueSetterMock;
//private Mock<IStorageAccountProvider> _accountProviderMock;

//private readonly JobHostQueuesOptions _queueConfiguration;
private readonly ISharedContextProvider _sharedContextProvider;
private SharedQueueHandler _sharedQueue;
//private readonly ISharedContextProvider _sharedContextProvider;
//private SharedQueueHandler _sharedQueue;

private readonly TestLoggerProvider _loggerProvider = new TestLoggerProvider();

Expand Down Expand Up @@ -67,7 +67,9 @@ public DispatchQueueTests()
}

[Fact(Skip = "Fix DispatchQueue")]
#pragma warning disable CS1998 // Async method lacks 'await' operators and will run synchronously
public async Task InMemoryDispatchQueueHandlerTest()
#pragma warning restore CS1998 // Async method lacks 'await' operators and will run synchronously
{
//string error = "no storage account found";
//_accountProviderMock.Setup(m => m.TryGetAccountAsync(ConnectionStringNames.Storage, It.IsAny<CancellationToken>())).
Expand Down Expand Up @@ -112,8 +114,11 @@ public async Task InMemoryDispatchQueueHandlerTest()
}

[Fact(Skip = "Fix DispatchQueue")]
#pragma warning disable CS1998 // Async method lacks 'await' operators and will run synchronously
public async Task QueueInitializationTest()
#pragma warning restore CS1998 // Async method lacks 'await' operators and will run synchronously
{
/*
// first initialization should be fine
await _sharedQueue.InitializeAsync(CancellationToken.None);
Expand All @@ -122,10 +127,13 @@ public async Task QueueInitializationTest()
() => _sharedQueue.InitializeAsync(CancellationToken.None));
Assert.Equal($"Expected state to be \"Created\" but actualy state is \"Initialized\", this is probably because methods are not called in correct order",
exception.Message);
*/
}

[Fact(Skip = "Fix DispatchQueue")]
#pragma warning disable CS1998 // Async method lacks 'await' operators and will run synchronously
public async Task HotPathNotificationTest()
#pragma warning restore CS1998 // Async method lacks 'await' operators and will run synchronously
{
//await _sharedQueue.InitializeAsync(CancellationToken.None);

Expand Down Expand Up @@ -168,8 +176,11 @@ public async Task HotPathNotificationTest()
}

[Fact(Skip = "Fix DispatchQueue")]
#pragma warning disable CS1998 // Async method lacks 'await' operators and will run synchronously
public async Task DequeueBehaviorTests()
#pragma warning restore CS1998 // Async method lacks 'await' operators and will run synchronously
{
/*
await _sharedQueue.InitializeAsync(CancellationToken.None);
var testCases = new List<TestCase>();
Expand Down Expand Up @@ -211,6 +222,7 @@ public async Task DequeueBehaviorTests()
Assert.Equal(a.TotalEnqueues, a.CallCount);
Assert.Equal(b.TotalEnqueues, b.CallCount);
Assert.Equal(0, c.CallCount);
*/
}

private class TestCase
Expand All @@ -222,6 +234,7 @@ private class TestCase

private Task RunDummyEnqueueAsync(List<TestCase> testCases)
{
/*
var enqueues = new List<Task>();
int index = 0;
foreach (var testcase in testCases)
Expand All @@ -241,6 +254,8 @@ private Task RunDummyEnqueueAsync(List<TestCase> testCases)
index++;
}
return Task.WhenAll(enqueues);
*/
return Task.CompletedTask;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public void UseEnvironment_Development_DefaultsOptionsCorrectly()
var queuesOptions = host.Services.GetService<IOptions<QueuesOptions>>();
Assert.Equal(TimeSpan.FromSeconds(2), queuesOptions.Value.MaxPollingInterval);

var singletonOptions = host.Services.GetService< IOptions<SingletonOptions>>();
var singletonOptions = host.Services.GetService<IOptions<SingletonOptions>>();
Assert.Equal(TimeSpan.FromSeconds(15), singletonOptions.Value.ListenerLockPeriod);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
<AssemblyName>Microsoft.Azure.WebJobs.Host.FunctionalTests</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.Host.FunctionalTests</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
<AssemblyName>Microsoft.Azure.WebJobs.Host.TestCommon</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.Host.TestCommon</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public async Task ExplicitReturnWins()
}

[Fact]
public async Task TestIndexError()
public void TestIndexError()
{
var ext = new MyExtension();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
<AssemblyName>Microsoft.Azure.WebJobs.Host.UnitTests</AssemblyName>
<RootNamespace>Microsoft.Azure.WebJobs.Host.UnitTests</RootNamespace>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
Expand Down
Loading

0 comments on commit 0f192b1

Please sign in to comment.