Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf regression in VSCode extension with bicepconfig.json configuration file #3045

Closed
anthony-c-martin opened this issue Jun 4, 2021 · 2 comments · Fixed by #3044
Closed

Perf regression in VSCode extension with bicepconfig.json configuration file #3045

anthony-c-martin opened this issue Jun 4, 2021 · 2 comments · Fixed by #3044
Labels
Needs: Triage 🔍

Comments

@anthony-c-martin
Copy link
Member

The Bicep 0.4.1 language server lags behind significantly when running on OSX with a bicepconfig.json file.

With dotnet profiling, looks like the issue is that the FileSystem.Watcher class is invoked a lot via the ConfigHelper class, which has known performance issues on non-Windows platforms (dotnet/runtime#42036):

image
@ghost ghost added the Needs: Triage 🔍 label Jun 4, 2021
@anthony-c-martin
Copy link
Member Author

Thanks @miqm for noticing and reporting this!

@anthony-c-martin anthony-c-martin mentioned this issue Jun 4, 2021
Merged
@miqm
Copy link
Collaborator

miqm commented Jun 4, 2021

Temporary fix: remove bicepconfig.json from folder tree.

@miqm miqm mentioned this issue Jul 16, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Needs: Triage 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable file watching for the Bicep linter config file Azure/bicep
2 participants
@miqm @anthony-c-martin