Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing default type definitions in LanguageConstants.CreateResourceProperties() #3356

Closed
anthony-c-martin opened this issue Jun 23, 2021 · 0 comments · Fixed by #7174
Closed
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@anthony-c-martin
Copy link
Member

Some of the top-level resource properties have a well-known type definition on the ARM side. We should match these definitions on the Bicep side.

This will be useful in providing enhanced validation for #3000

For example, "identity" has a definition similar to the following on the ARM side:

interface Identity {
  userAssignedIdentities: { [msiId: string]: string },
  principalId: string,
  tenantId: string,
  type: 'SystemAssigned' | 'UserAssigned' | 'None',
}
@ghost ghost added the Needs: Triage 🔍 label Jun 23, 2021
@alex-frankel alex-frankel added enhancement New feature or request and removed Needs: Triage 🔍 labels Jun 24, 2021
@alex-frankel alex-frankel modified the milestones: Committed Backlog, v0.5 Jun 24, 2021
@stephaniezyen stephaniezyen modified the milestones: v0.5, v1.0 Mar 21, 2022
@stephaniezyen stephaniezyen added the good first issue Good for newcomers label Mar 21, 2022
@stephaniezyen stephaniezyen modified the milestones: v1.0, v0.8 Apr 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants