Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipule parameters per annotation #4184

Open
dciborow opened this issue Aug 27, 2021 · 1 comment
Open

Multipule parameters per annotation #4184

dciborow opened this issue Aug 27, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@dciborow
Copy link
Collaborator

dciborow commented Aug 27, 2021

I'm always frustrated when...
...my parameters take up 3/4ths of my file length.

Describe the solution you'd like
Having lists of allowed values quickly increases line count. Other annotations, like "@secure()" result in +3 lines to a param. If single annotations could be stacked, there would be a great improvement in readability.

Before

@secure()
param _artifactsLocationSasToken    string = ''

@secure()
param servicePrincipalClientID      string = ''

@secure()
param servicePrincipalSecret        string = ''

After

@secure()
param _artifactsLocationSasToken    string = ''
param servicePrincipalClientID      string = ''
param servicePrincipalSecret        string = ''

Before

@allowed([
  'S1'
  'S2'
  'S3'
  'P1'
  'P2'
  'P3'
  'P1V2'
  'P2V2'
  'P3V2'
])
param nonAISkillSku                 string = 'P3V2'

@allowed([
  'S1'
  'S2'
  'S3'
  'P1'
  'P2'
  'P3'
  'P1V2'
  'P2V2'
  'P3V2'
])
param AISkillSku                    string = 'P3V2'

@allowed([
  'S1'
  'S2'
  'S3'
  'P1'
  'P2'
  'P3'
  'P1V2'
  'P2V2'
  'P3V2'
])
param APIServerSku                  string = 'P3V2'

After

@allowed([
  'S1'
  'S2'
  'S3'
  'P1'
  'P2'
  'P3'
  'P1V2'
  'P2V2'
  'P3V2'
])
param nonAISkillSku                string = 'P3V2'
param AISkillSku                   string = 'P3V2'
param APIServerSku                 string = 'P3V2'
@dciborow dciborow added the enhancement New feature or request label Aug 27, 2021
@ghost ghost added the Needs: Triage 🔍 label Aug 27, 2021
@dciborow
Copy link
Collaborator Author

#586 would help too. But at least in VSCode the collapse turns annotations into one liners.

With this suggested notation, and with VSCode, 30 lines of annotation would collapse to 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants