-
Notifications
You must be signed in to change notification settings - Fork 235
Contribution guidlines, codeowners, issues and PR templates. #3
Conversation
|
||
--- | ||
|
||
GitHub username(s): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need any filled out examples for the templates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specifically this one, but any of the templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not include options to edit/remove. Once accepted should be there forever, and only in very rare circumstances we will process an edit.
Dont use JSON-LD as a bar, we dont support JSON-LD, only the DTDL subset
Nit. Why snake_casing for md files? usually in docs, we use hyphen-casing for .md files.
We will see users ask to remove models. It will be better to get in front of these issues by giving them a means to request it be done than to deal with pull requests removing files that are then not removed from devicemodels.azure.com.
Actually, we use the JSON-LD implementation of DTDL. The DTDL specification is not coupled to JSON-LD as the only storage mechanism. This repository is.
Actually, the docs that were generated automatically are in SCREAMING_SNAKE_CASE.md. Example: CODE_OF_CONDUCT.md |
Changes approved by other contributors.
No description provided.