Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Contribution guidlines, codeowners, issues and PR templates. #3

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Contribution guidlines, codeowners, issues and PR templates. #3

merged 3 commits into from
Oct 2, 2020

Conversation

montgomp
Copy link
Contributor

@montgomp montgomp commented Oct 2, 2020

No description provided.


---

GitHub username(s):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need any filled out examples for the templates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specifically this one, but any of the templates.

Copy link
Member

@rido-min rido-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not include options to edit/remove. Once accepted should be there forever, and only in very rare circumstances we will process an edit.

Dont use JSON-LD as a bar, we dont support JSON-LD, only the DTDL subset

Nit. Why snake_casing for md files? usually in docs, we use hyphen-casing for .md files.

.github/ISSUE_TEMPLATE/code_owner_request.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/code_owner_request.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@montgomp
Copy link
Contributor Author

montgomp commented Oct 2, 2020

I would not include options to edit/remove. Once accepted should be there forever, and only in very rare circumstances we will process an edit.

We will see users ask to remove models. It will be better to get in front of these issues by giving them a means to request it be done than to deal with pull requests removing files that are then not removed from devicemodels.azure.com.

Dont use JSON-LD as a bar, we dont support JSON-LD, only the DTDL subset

Actually, we use the JSON-LD implementation of DTDL. The DTDL specification is not coupled to JSON-LD as the only storage mechanism. This repository is.

Nit. Why snake_casing for md files? usually in docs, we use hyphen-casing for .md files.

Actually, the docs that were generated automatically are in SCREAMING_SNAKE_CASE.md. Example: CODE_OF_CONDUCT.md

@montgomp montgomp dismissed rido-min’s stale review October 2, 2020 17:57

Changes approved by other contributors.

@montgomp montgomp merged commit 377c6ac into Azure:main Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants