-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Karpenter NodeClaim API in workspace #366
Conversation
c1b343f
to
1ccf48d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
- Coverage 62.89% 60.62% -2.27%
==========================================
Files 14 29 +15
Lines 1307 2301 +994
==========================================
+ Hits 822 1395 +573
- Misses 447 835 +388
- Partials 38 71 +33 ☔ View full report in Codecov by Sentry. |
what happened between k8s 1.27 and 1.29? |
1ccf48d
to
14423c6
Compare
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
14423c6
to
26f3f79
Compare
@bangqipropel any k8s version before 1.29 will use |
I see, before I saw 1.27 also, that was why I asked |
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
e65bcfe
to
ae9c77e
Compare
Reason for Change:
nodeClaims
API.Workspace controller won't migrate the current
machine
nodes. The behavior for CRUD operation:Create
nodeClaims
orMachine
APIs will be used to create a node based on featureGate,Ownership
machines
andnodeClaims
objects which created by the same workspace will be associated to it until got deleted.Delete
Deleting the workspace will delete both (if any) old
machines
objects andnodeClaims
.Add unit tests for supporting node claims, and managing migrated clusters (both machines and nodeClaims).
Replace the deprecated func
FromInt
withFromInt32
.Update error message lint warning, start with lowercase characters.
Requirements
Issue Fixed:
#339
Notes for Reviewers: