Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add num iteration and start iteration to lightgbm model #1024

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Apr 16, 2021

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #1024 (bba7244) into master (2c223f6) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
- Coverage   84.18%   84.17%   -0.02%     
==========================================
  Files         201      201              
  Lines        9306     9338      +32     
  Branches      554      555       +1     
==========================================
+ Hits         7834     7860      +26     
- Misses       1472     1478       +6     
Impacted Files Coverage Δ
...osoft/ml/spark/lightgbm/LightGBMModelMethods.scala 66.66% <66.66%> (ø)
.../microsoft/ml/spark/lightgbm/LightGBMBooster.scala 87.50% <77.77%> (-0.93%) ⬇️
...a/com/microsoft/ml/spark/lightgbm/TrainUtils.scala 77.27% <83.33%> (-0.03%) ⬇️
...crosoft/ml/spark/lightgbm/LightGBMClassifier.scala 90.58% <100.00%> (+0.22%) ⬆️
...icrosoft/ml/spark/lightgbm/LightGBMConstants.scala 100.00% <100.00%> (ø)
...m/microsoft/ml/spark/lightgbm/LightGBMParams.scala 88.15% <100.00%> (+0.58%) ⬆️
...m/microsoft/ml/spark/lightgbm/LightGBMRanker.scala 60.65% <100.00%> (+1.33%) ⬆️
...icrosoft/ml/spark/lightgbm/LightGBMRegressor.scala 70.00% <100.00%> (+1.25%) ⬆️
...com/microsoft/ml/spark/core/utils/AsyncUtils.scala 65.00% <0.00%> (-5.00%) ⬇️
...a/com/microsoft/ml/spark/io/http/HTTPClients.scala 83.33% <0.00%> (-3.34%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c223f6...bba7244. Read the comment docs.

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but other than that LGTM

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants