-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add num iteration and start iteration to lightgbm model #1024
feat: add num iteration and start iteration to lightgbm model #1024
Conversation
3a06dcc
to
d9ec7b8
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
- Coverage 84.18% 84.17% -0.02%
==========================================
Files 201 201
Lines 9306 9338 +32
Branches 554 555 +1
==========================================
+ Hits 7834 7860 +26
- Misses 1472 1478 +6
Continue to review full report at Codecov.
|
src/main/scala/com/microsoft/ml/spark/lightgbm/LightGBMModelMethods.scala
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit but other than that LGTM
src/main/scala/com/microsoft/ml/spark/lightgbm/LightGBMModelMethods.scala
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
resolves issue Transform at the best iteration for LightGBMClassifier #1006