Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fixing build warnings #1080

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Conversation

memoryz
Copy link
Contributor

@memoryz memoryz commented Jun 11, 2021

No description provided.

@memoryz
Copy link
Contributor Author

memoryz commented Jun 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jun 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #1080 (e6a26ca) into master (007a884) will increase coverage by 7.63%.
The diff coverage is 86.89%.

❗ Current head e6a26ca differs from pull request most recent head 2dbc4bc. Consider uploading reports for the commit 2dbc4bc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
+ Coverage   77.26%   84.90%   +7.63%     
==========================================
  Files         230      206      -24     
  Lines        9317     9726     +409     
  Branches      506      552      +46     
==========================================
+ Hits         7199     8258    +1059     
+ Misses       2118     1468     -650     
Impacted Files Coverage Δ
.../microsoft/ml/spark/automl/HyperparamBuilder.scala 47.61% <0.00%> (ø)
...soft/ml/spark/cognitive/TextAnalyticsSchemas.scala 100.00% <ø> (ø)
...a/com/microsoft/ml/spark/core/utils/RowUtils.scala 0.00% <0.00%> (ø)
...ala/com/microsoft/ml/spark/downloader/Schema.scala 61.53% <0.00%> (ø)
...icrosoft/ml/spark/io/binary/BinaryFileReader.scala 73.91% <ø> (ø)
...a/com/microsoft/ml/spark/io/image/ImageUtils.scala 88.23% <ø> (+15.68%) ⬆️
...ft/ml/spark/lightgbm/booster/LightGBMBooster.scala 87.86% <ø> (ø)
...ft/ml/spark/lightgbm/dataset/LightGBMDataset.scala 83.75% <ø> (ø)
...microsoft/ml/spark/lightgbm/params/FObjParam.scala 100.00% <ø> (ø)
...l/spark/lightgbm/params/LightGBMBoosterParam.scala 100.00% <ø> (ø)
... and 320 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebee5dc...2dbc4bc. Read the comment docs.

@memoryz
Copy link
Contributor Author

memoryz commented Jun 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jun 12, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jun 12, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jun 12, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Jun 14, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are such a legend :)

@mhamilton723 mhamilton723 merged commit e7d4eca into microsoft:master Jun 14, 2021
@memoryz memoryz deleted the jasowang/buildwrn branch June 14, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants