Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added label conversion for VW binary classifier (0/1 -> -1/1) #700

Merged
merged 7 commits into from
Oct 9, 2019

Conversation

eisber
Copy link
Collaborator

@eisber eisber commented Oct 4, 2019

It's enabled by default, but can be disabled.

@eisber
Copy link
Collaborator Author

eisber commented Oct 4, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #700 into master will increase coverage by 0.03%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage   79.99%   80.03%   +0.03%     
==========================================
  Files         229      229              
  Lines        9118     9129      +11     
  Branches      469      473       +4     
==========================================
+ Hits         7294     7306      +12     
+ Misses       1824     1823       -1
Impacted Files Coverage Δ
...osoft/ml/spark/core/schema/DatasetExtensions.scala 100% <ø> (ø) ⬆️
...microsoft/ml/spark/vw/VowpalWabbitClassifier.scala 90.9% <100%> (+4.54%) ⬆️
...a/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala 90.11% <66.66%> (ø) ⬆️
...osoft/ml/spark/io/http/PartitionConsolidator.scala 95.55% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44dafd...d6d6071. Read the comment docs.

@eisber
Copy link
Collaborator Author

eisber commented Oct 4, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eisber
Copy link
Collaborator Author

eisber commented Oct 4, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eisber
Copy link
Collaborator Author

eisber commented Oct 8, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eisber
Copy link
Collaborator Author

eisber commented Oct 8, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 previously approved these changes Oct 8, 2019
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

@eisber
Copy link
Collaborator Author

eisber commented Oct 8, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eisber
Copy link
Collaborator Author

eisber commented Oct 9, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 04a2fbd into microsoft:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants