fix: ensuring we are checking the storage accounts on the whole subscripti…

src/util/azure/account.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 import { StorageManagementClient } from '@azure/arm-storage';
-import { filteredList, ListItem, newItemPrompt } from '../prompt/list';
+import { newItemPrompt } from '../prompt/list';
 import { Aborter, ServiceURL, SharedKeyCredential } from '@azure/storage-blob';
 import { DeviceTokenCredentials } from '@azure/ms-rest-nodeauth';
 import { AddOptions, Logger } from '../shared/types';
@@ -12,17 +12,6 @@ import { ResourceGroup } from './resource-group';
 import { generateName } from '../prompt/name-generator';
 import { spinner } from '../prompt/spinner';
 
-interface AccountDetails extends ListItem {
-  id: string;
-  name: string;
-  location: string;
-}
-
-const accountPromptOptions = {
-  id: 'account',
-  message: 'Under which storage account should we put this static site?'
-};
-
 const newAccountPromptOptions = {
   id: 'newAccount',
   message: 'Enter a name for the new storage account:',
@@ -46,7 +35,8 @@ export async function getAccount(
   let needToCreateAccount = false;
 
   spinner.start('Fetching storage accounts');
-  const accounts = await client.storageAccounts.listByResourceGroup(resourceGroup.name);
+  // const accounts = await client.storageAccounts.listByResourceGroup(resourceGroup.name);
+  const accounts = await client.storageAccounts;
   spinner.stop();
 
   function getInitialAccountName() {
@@ -64,8 +54,9 @@ export async function getAccount(
   newAccountPromptOptions.validate = validateAccountName;
 
   if (accountName) {
-    const account = accounts.find(acc => acc.name === accountName);
-    if (!!account) {
+    const result = await accounts.checkNameAvailability(accountName);
+
+    if (!result.nameAvailable) {
       // account exists
       // TODO: check account configuration
       logger.info(`Using existing account ${accountName}`);
@@ -82,13 +73,16 @@ export async function getAccount(
 
     if (!options.manual) {
       // quickstart - create w/ default name
+
       accountName = await generateDefaultAccountName(initialName);
-      needToCreateAccount = true;
-    } else {
-      // select from list or create new
-      const result = await filteredList(accounts as AccountDetails[], accountPromptOptions, newAccountPromptOptions);
-      needToCreateAccount = !!result.newAccount;
-      accountName = result.newAccount || result.account.name;
+      const availableResult = await client.storageAccounts.checkNameAvailability(accountName);
+
+      if (!availableResult.nameAvailable) {
+        logger.info(`Account ${accountName} already exist on subscription`);
+        logger.info(`Using existing account ${accountName}`);
+      } else {
+        needToCreateAccount = true;
+      }
     }
   }