This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Alignment Fix for deploymentDetails page #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spryor
reviewed
Feb 15, 2019
| export const formatTime = (value) => { | ||
| if (value) { | ||
| const time = moment.utc(value).local(); | ||
| return (time.unix() > 0) ? time.format(DEFAULT_TIME_FORMAT) : '' || Config.emptyFieldValue; |
There was a problem hiding this comment.
Config.emptyFieldValue || ''
Should this not be the correct order?
There was a problem hiding this comment.
No, we have to view the previous expression holistically. I could add a pair of brackets to make it clear.
((time.unix() > 0) ? time.format(DEFAULT_TIME_FORMAT) : '') || Config.emptyFieldValue;
spryor
approved these changes
Feb 15, 2019
ppathan
approved these changes
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change?
Description, Context, Motivation
The summary section in the deployment details page was misaligned and also it was using 'TimeRenderer' component which is used to style pcs-grid. In this PR I've taken out some methods/const from 'PcsGridConfig' to 'methods' file in utilities folder, so I can apply styling to 'TimeRenderer' separately and summary stat seperately.
...
Checklist:
This change is