docs: Add jobs tolerations attribute in helm chart docs #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add attribute definition for child chart Jobs
nilekhc
reviewed
Jun 29, 2022
aramase
changed the title
aramase
requested changes
Jun 29, 2022
There was a problem hiding this comment.
Thank you for the PR!
Please update the yamls in the manifest_staging/ folder, where we host the staging charts and deployment yamls. All the yaml changes will then be promoted into the released charts folder with the next release.
|
@dtotopus Thanks for opening the PR. I have left couple nit. Could you move these changes to manifest_staging dir. We promote this to Also, could you add semantic commit? |
|
Thanks a lot for the comments! Updated the PR |
aramase
reviewed
Jun 30, 2022
manifest_staging/charts/csi-secrets-store-provider-azure/README.md
Outdated
Show resolved
Hide resolved
manifest_staging/charts/csi-secrets-store-provider-azure/README.md
Outdated
Show resolved
Hide resolved
…E.md Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
…E.md Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com>
aramase
approved these changes
Jul 1, 2022
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add attribute definition for child chart Job tolerations
Reason for Change:
Current documentation doesn't specify that in order for tolerations to work child chart requires tolerations to be defined. Attribute isn't listed in the README.md
Is this a chart or deployment yaml update?
Documentation update only
Does this change contain code from or inspired by another project?
No