Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "Database" instead of requiring "Initial Catalog" in connection string #72

Closed
zijchen opened this issue Jan 11, 2022 · 2 comments
Closed
Labels
enhancement New feature or request idle Inactive for 14 days v2-candidate

Comments

@zijchen
Copy link
Contributor

zijchen commented Jan 11, 2022

Database and Initial Catalog are interchangeable in a MSSQL connection string: https://docs.microsoft.com/dotnet/api/system.data.sqlclient.sqlconnectionstringbuilder.initialcatalog#remarks

However if only "Database" is supplied to sql-action, following error is thrown:

Error: Missing required keys in connection string. Please ensure that the keys 'User Id', 'Password', 'Initial Catalog' are provided in the connection string.

@zijchen zijchen added enhancement New feature or request need-to-triage Requires investigation labels Jan 11, 2022
@dzsquared dzsquared removed the need-to-triage Requires investigation label Jan 24, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Feb 7, 2022
@zijchen
Copy link
Contributor Author

zijchen commented Jun 21, 2022

This was fixed in #96

@zijchen zijchen closed this as completed Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idle Inactive for 14 days v2-candidate
Projects
None yet
Development

No branches or pull requests

2 participants