Remove mssql dependency, use tediousjs/connection-string for parsing #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijchen
commented
Jun 12, 2024
dzsquared
previously approved these changes
Jun 12, 2024
…chen/update-mssql
zijchen
had a problem deploying
to
Automation test
GitHub Actions
Failure
zijchen
had a problem deploying
to
Automation test
GitHub Actions
Failure
zijchen
changed the title
chlafreniere
approved these changes
Jun 19, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mssql dependency since we only use it for parsing connection string now that everything else is using go-sqlcmd to test connection. Now we use tediousjs/connection-string for parsing, which was what mssql was using under the hood